-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: deadlock in controller #14304
fix: deadlock in controller #14304
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #14304 +/- ##
=======================================
Coverage 49.75% 49.76%
=======================================
Files 261 261
Lines 44659 44659
=======================================
+ Hits 22222 22225 +3
+ Misses 20251 20249 -2
+ Partials 2186 2185 -1
☔ View full report in Codecov by Sentry. |
Please submit PR against master, we'll cherry-pick into release-2.8. |
Changed the target branch, but diff is gonna be weird until rebase. |
/cherry-pick release-2.8 |
Signed-off-by: Alexandre Gaudreault <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
Signed-off-by: Alexandre Gaudreault <[email protected]>
Signed-off-by: Alexandre Gaudreault <[email protected]> Co-authored-by: Alexandre Gaudreault <[email protected]>
Signed-off-by: Alexandre Gaudreault <[email protected]>
Signed-off-by: Alexandre Gaudreault <[email protected]>
When the config
resource.ignoreResourceUpdatesEnabled: 'true'
is true and the application controller log level is set todebug
, the controller hangs.