chore: just use strings.TrimSuffix #14248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suzaku
force-pushed
the
rm-unnecessary-func
branch
from
1089e6c to
5a5b91c
Compare
suzaku
changed the title
It's implemented in the same way in the standard library. Signed-off-by: satoru <[email protected]>
suzaku
force-pushed
the
rm-unnecessary-func
branch
from
5a5b91c to
2f0f7f0
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #14248 +/- ##
==========================================
- Coverage 49.78% 49.76% -0.02%
==========================================
Files 261 261
Lines 44672 44667 -5
==========================================
- Hits 22238 22229 -9
- Misses 20249 20252 +3
- Partials 2185 2186 +1
☔ View full report in Codecov by Sentry. |
blakepettersson
approved these changes
Jun 28, 2023
yyzxw
pushed a commit
to yyzxw/argo-cd
that referenced
this pull request
Aug 9, 2023
It's implemented in the same way in the standard library. Signed-off-by: satoru <[email protected]>
tesla59
pushed a commit
to tesla59/argo-cd
that referenced
this pull request
Dec 16, 2023
It's implemented in the same way in the standard library. Signed-off-by: satoru <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's implemented in the same way in the standard library.