chore: remove useless lines from argocd_repo_server.go #14154
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #14154 +/- ##
==========================================
+ Coverage 49.60% 49.78% +0.17%
==========================================
Files 256 261 +5
Lines 43829 44672 +843
==========================================
+ Hits 21741 22238 +497
- Misses 19950 20249 +299
- Partials 2138 2185 +47 ☔ View full report in Codecov by Sentry. |
| if cmdutil.LogFormat == "" { | ||
| cmdutil.LogFormat = os.Getenv("ARGOCD_REPO_SERVER_LOGLEVEL") | ||
| cmdutil.LogFormat = os.Getenv("ARGOCD_REPO_SERVER_LOGFORMAT") | ||
| } |
There was a problem hiding this comment.
@ishitasequeira do you remember what these 3 lines were for from f533ed1 ?
Looks to me like line 205 is always gonna overwrite this value.
There was a problem hiding this comment.
It's from a very long time. But looks like we might have missed catching that. I think we can completely remove lines 202-204, that is the entire if check.
There was a problem hiding this comment.
@chanhz would you mind updating the PR to delete all 3 lines?
There was a problem hiding this comment.
sure, thx for quick response.
| if cmdutil.LogFormat == "" { | ||
| cmdutil.LogFormat = os.Getenv("ARGOCD_REPO_SERVER_LOGLEVEL") | ||
| cmdutil.LogFormat = os.Getenv("ARGOCD_REPO_SERVER_LOGFORMAT") | ||
| } |
There was a problem hiding this comment.
It's from a very long time. But looks like we might have missed catching that. I think we can completely remove lines 202-204, that is the entire if check.
chanhz
changed the title
|
@chanhz , you would have to fix the |
chanhz
changed the title
|
@chanhz can you fix DCO? |
Head branch was pushed to by a user without write access
Signed-off-by: hongzhou.chen <[email protected]>
Signed-off-by: hongzhou.chen <[email protected]>
Signed-off-by: hongzhou.chen <[email protected]>
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Please see Contribution FAQs if you have questions about your pull-request.