-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui): soften readiness gate failure message (#13972) #14076
fix(ui): soften readiness gate failure message (#13972) #14076
Conversation
Signed-off-by: Michael Crenshaw <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #14076 +/- ##
=======================================
Coverage 49.57% 49.57%
=======================================
Files 256 256
Lines 43920 43920
=======================================
Hits 21773 21773
Misses 19985 19985
Partials 2162 2162 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Michael Crenshaw <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/cherry-pick release-2.7 |
Cherry-pick failed with |
…proj#14076) * fix(ui): soften readiness gate failure message (argoproj#13972) Signed-off-by: Michael Crenshaw <[email protected]> * null check everything Signed-off-by: Michael Crenshaw <[email protected]> --------- Signed-off-by: Michael Crenshaw <[email protected]>
) * fix(ui): soften readiness gate failure message (#13972) * null check everything --------- Signed-off-by: Michael Crenshaw <[email protected]>
…proj#14076) (argoproj#14079) * fix(ui): soften readiness gate failure message (argoproj#13972) * null check everything --------- Signed-off-by: Michael Crenshaw <[email protected]> Signed-off-by: schakrad <[email protected]>
…proj#14076) * fix(ui): soften readiness gate failure message (argoproj#13972) Signed-off-by: Michael Crenshaw <[email protected]> * null check everything Signed-off-by: Michael Crenshaw <[email protected]> --------- Signed-off-by: Michael Crenshaw <[email protected]>
…proj#14076) * fix(ui): soften readiness gate failure message (argoproj#13972) Signed-off-by: Michael Crenshaw <[email protected]> * null check everything Signed-off-by: Michael Crenshaw <[email protected]> --------- Signed-off-by: Michael Crenshaw <[email protected]>
Two changes:
Fixes #13972