Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): soften readiness gate failure message (#13972) #14076

Merged
merged 2 commits into from
Jun 15, 2023

Conversation

crenshaw-dev
Copy link
Member

Two changes:

  • Don't show the message until all containers are ready (because readiness gates don't matter if the containers aren't ready)
  • Soften the warning text and presentation ("not passing" instead of "failure", yellow border instead of red)

image

Fixes #13972

Copy link
Collaborator

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (f63b856) 49.57% compared to head (6403beb) 49.57%.

❗ Current head 6403beb differs from pull request most recent head c08667d. Consider uploading reports for the commit c08667d to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #14076   +/-   ##
=======================================
  Coverage   49.57%   49.57%           
=======================================
  Files         256      256           
  Lines       43920    43920           
=======================================
  Hits        21773    21773           
  Misses      19985    19985           
  Partials     2162     2162           

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Michael Crenshaw <[email protected]>
Copy link
Collaborator

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crenshaw-dev crenshaw-dev enabled auto-merge (squash) June 15, 2023 14:54
@crenshaw-dev
Copy link
Member Author

/cherry-pick release-2.7

@crenshaw-dev crenshaw-dev merged commit bbc51fb into argoproj:master Jun 15, 2023
@gcp-cherry-pick-bot
Copy link

Cherry-pick failed with Merge error bbc51fba03b2888d39a4271e07c926cc7c268de7 into temp-cherry-pick-3bdb95-release-2.7

@crenshaw-dev crenshaw-dev deleted the readiness-gate-warning branch June 15, 2023 16:01
crenshaw-dev added a commit to crenshaw-dev/argo-cd that referenced this pull request Jun 15, 2023
…proj#14076)

* fix(ui): soften readiness gate failure message (argoproj#13972)

Signed-off-by: Michael Crenshaw <[email protected]>

* null check everything

Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: Michael Crenshaw <[email protected]>
crenshaw-dev added a commit that referenced this pull request Jun 15, 2023
)

* fix(ui): soften readiness gate failure message (#13972)



* null check everything



---------

Signed-off-by: Michael Crenshaw <[email protected]>
schakrad pushed a commit to schakrad/argo-cd that referenced this pull request Jul 24, 2023
…proj#14076) (argoproj#14079)

* fix(ui): soften readiness gate failure message (argoproj#13972)

* null check everything

---------

Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: schakrad <[email protected]>
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
…proj#14076)

* fix(ui): soften readiness gate failure message (argoproj#13972)

Signed-off-by: Michael Crenshaw <[email protected]>

* null check everything

Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: Michael Crenshaw <[email protected]>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
…proj#14076)

* fix(ui): soften readiness gate failure message (argoproj#13972)

Signed-off-by: Michael Crenshaw <[email protected]>

* null check everything

Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: Michael Crenshaw <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misleading Readiness Gate error in Argo CD UI
2 participants