-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add gofmt to golangci-lint in Makefile and .github/workflows/ci-build.yaml #13729
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #13729 +/- ##
=======================================
Coverage 49.76% 49.76%
=======================================
Files 261 261
Lines 44676 44676
=======================================
Hits 22232 22232
Misses 20257 20257
Partials 2187 2187
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
186c00a
to
0f2c72e
Compare
526b7e0
to
40488aa
Compare
I'm gonna save this until after we cut 2.8-rc1. Wanna avoid anything that will reduce PR velocity until then. |
No worries. Let me know when you do it and I'll rebase just before that. |
@crenshaw-dev I have manually rebased this in case you want to merge it since v2.8.0-rc1 has been released. |
…build.yaml Signed-off-by: Denis Dupeyron <[email protected]>
Signed-off-by: Denis Dupeyron <[email protected]>
Signed-off-by: Denis Dupeyron <[email protected]>
…i-build.yaml (argoproj#13729) * fix: add gofmt to golangci-lint in Makefile and .github/workflows/ci-build.yaml Signed-off-by: Denis Dupeyron <[email protected]> * fix go formatting issues using gofmt Signed-off-by: Denis Dupeyron <[email protected]> * chore: simplify go code using gofmt Signed-off-by: Denis Dupeyron <[email protected]> --------- Signed-off-by: Denis Dupeyron <[email protected]>
…i-build.yaml (argoproj#13729) * fix: add gofmt to golangci-lint in Makefile and .github/workflows/ci-build.yaml Signed-off-by: Denis Dupeyron <[email protected]> * fix go formatting issues using gofmt Signed-off-by: Denis Dupeyron <[email protected]> * chore: simplify go code using gofmt Signed-off-by: Denis Dupeyron <[email protected]> --------- Signed-off-by: Denis Dupeyron <[email protected]>
Out of curiosity I ran
gofmt
at the top of the repo and it found quite a few formatting issues and simplifications. This PR addsgofmt
togolangci-lint
inMakefile
and.github/workflows/ci-build.yaml
to automatically detect/fix these issues in the future. It also applies the relevant changes provided by runninggofmt
.Checklist: