Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm honor os env #1306

Merged
merged 1 commit into from
Mar 21, 2019
Merged

helm honor os env #1306

merged 1 commit into from
Mar 21, 2019

Conversation

1337andre
Copy link
Contributor

it would be nice, if helm would honor env variables like https_proxy.

@CLAassistant
Copy link

CLAassistant commented Mar 21, 2019

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

Codecov Report

Merging #1306 into master will decrease coverage by 25.3%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1306       +/-   ##
===========================================
- Coverage   37.08%   11.78%   -25.31%     
===========================================
  Files          59       70       +11     
  Lines        9093    30178    +21085     
===========================================
+ Hits         3372     3556      +184     
- Misses       5217    26105    +20888     
- Partials      504      517       +13
Impacted Files Coverage Δ
util/helm/helm.go 63.63% <100%> (+0.3%) ⬆️
server/project/project.pb.gw.go 0% <0%> (ø) ⬆️
server/application/forwarder_overwrite.go 100% <0%> (ø) ⬆️
pkg/apis/application/v1alpha1/types.go 18.48% <0%> (ø)
pkg/apis/application/v1alpha1/generated.pb.go 0.55% <0%> (ø)
pkg/apis/application/v1alpha1/register.go 0% <0%> (ø)
server/project/project.pb.go 0.85% <0%> (ø)
...apis/application/v1alpha1/zz_generated.deepcopy.go 2.98% <0%> (ø)
server/application/application.pb.go 0.55% <0%> (ø)
test/testdata.go 0% <0%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d60fb2b...9073d6e. Read the comment docs.

Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants