chore: add skaffold dev configuration #11980
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11980 +/- ##
==========================================
- Coverage 49.73% 49.46% -0.28%
==========================================
Files 274 274
Lines 48948 48771 -177
==========================================
- Hits 24343 24123 -220
- Misses 22230 22285 +55
+ Partials 2375 2363 -12 ☔ View full report in Codecov by Sentry. |
blakepettersson
force-pushed
the
chore/add-skaffold-config
branch
from
f14e658 to
7c5d1c1
Compare
4 tasks
blakepettersson
force-pushed
the
chore/add-skaffold-config
branch
from
7c5d1c1 to
e33a63f
Compare
drpaneas
suggested changes
Feb 27, 2023
There was a problem hiding this comment.
I've tested it out and it works great. However, I did run into one small issue. It seems that the argocd namespace needs to be created before running Skaffold.
#41 DONE 2.7s
Build [quay.io/argoproj/argocd] succeeded
Tags used in deployment:
- quay.io/argoproj/argocd -> quay.io/argoproj/argocd:d137b2680f58f7794c3aad39421cd62f49e55fe5ec3cf3e033f954d0be7c3924
Starting deploy...
Loading images into kind cluster nodes...
- quay.io/argoproj/argocd:d137b2680f58f7794c3aad39421cd62f49e55fe5ec3cf3e033f954d0be7c3924 -> Loaded
Images loaded in 26.848 seconds
- customresourcedefinition.apiextensions.k8s.io/applications.argoproj.io created
- customresourcedefinition.apiextensions.k8s.io/applicationsets.argoproj.io created
- customresourcedefinition.apiextensions.k8s.io/appprojects.argoproj.io created
- clusterrole.rbac.authorization.k8s.io/argocd-application-controller created
- clusterrolebinding.rbac.authorization.k8s.io/argocd-application-controller created
- Error from server (NotFound): error when creating "STDIN": namespaces "argocd" not found
- Error from server (NotFound): error when creating "STDIN": namespaces "argocd" not found
- Error from server (NotFound): error when creating "STDIN": namespaces "argocd" not found
- Error from server (NotFound): error when creating "STDIN": namespaces "argocd" not found
- Error from server (NotFound): error when creating "STDIN": namespaces "argocd" not found
- Error from server (NotFound): error when creating "STDIN": namespaces "argocd" not found
- Error from server (NotFound): error when creating "STDIN": namespaces "argocd" not found
- Error from server (NotFound): error when creating "STDIN": namespaces "argocd" not found
- Error from server (NotFound): error when creating "STDIN": namespaces "argocd" not found
- Error from server (NotFound): error when creating "STDIN": namespaces "argocd" not found
- Error from server (NotFound): error when creating "STDIN": namespaces "argocd" not found
- Error from server (NotFound): error when creating "STDIN": namespaces "argocd" not found
- Error from server (NotFound): error when creating "STDIN": namespaces "argocd" not found
- Error from server (NotFound): error when creating "STDIN": namespaces "argocd" not found
- Error from server (NotFound): error when creating "STDIN": namespaces "argocd" not found
- Error from server (NotFound): error when creating "STDIN": namespaces "argocd" not found
- Error from server (NotFound): error when creating "STDIN": namespaces "argocd" not found
- Error from server (NotFound): error when creating "STDIN": namespaces "argocd" not found
- Error from server (NotFound): error when creating "STDIN": namespaces "argocd" not found
- Error from server (NotFound): error when creating "STDIN": namespaces "argocd" not found
- Error from server (NotFound): error when creating "STDIN": namespaces "argocd" not found
- Error from server (NotFound): error when creating "STDIN": namespaces "argocd" not found
- Error from server (NotFound): error when creating "STDIN": namespaces "argocd" not found
- Error from server (NotFound): error when creating "STDIN": namespaces "argocd" not found
- Error from server (NotFound): error when creating "STDIN": namespaces "argocd" not found
- Error from server (NotFound): error when creating "STDIN": namespaces "argocd" not found
- Error from server (NotFound): error when creating "STDIN": namespaces "argocd" not found
- Error from server (NotFound): error when creating "STDIN": namespaces "argocd" not found
- Error from server (NotFound): error when creating "STDIN": namespaces "argocd" not found
- Error from server (NotFound): error when creating "STDIN": namespaces "argocd" not found
- Error from server (NotFound): error when creating "STDIN": namespaces "argocd" not found
- Error from server (NotFound): error when creating "STDIN": namespaces "argocd" not found
- Error from server (NotFound): error when creating "STDIN": namespaces "argocd" not found
- Error from server (NotFound): error when creating "STDIN": namespaces "argocd" not found
- Error from server (NotFound): error when creating "STDIN": namespaces "argocd" not found
- Error from server (NotFound): error when creating "STDIN": namespaces "argocd" not found
- Error from server (NotFound): error when creating "STDIN": namespaces "argocd" not found
- Error from server (NotFound): error when creating "STDIN": namespaces "argocd" not found
- Error from server (NotFound): error when creating "STDIN": namespaces "argocd" not found
- Error from server (NotFound): error when creating "STDIN": namespaces "argocd" not found
- Error from server (NotFound): error when creating "STDIN": namespaces "argocd" not found
- Error from server (NotFound): error when creating "STDIN": namespaces "argocd" not found
- Error from server (NotFound): error when creating "STDIN": namespaces "argocd" not found
- Error from server (NotFound): error when creating "STDIN": namespaces "argocd" not found
- Error from server (NotFound): error when creating "STDIN": namespaces "argocd" not found
- Error from server (NotFound): error when creating "STDIN": namespaces "argocd" not found
- Error from server (NotFound): error when creating "STDIN": namespaces "argocd" not found
- Error from server (NotFound): error when creating "STDIN": namespaces "argocd" not found
- Error from server (NotFound): error when creating "STDIN": namespaces "argocd" not found
Cleaning up...
- customresourcedefinition.apiextensions.k8s.io "applications.argoproj.io" deleted
- customresourcedefinition.apiextensions.k8s.io "applicationsets.argoproj.io" deleted
- customresourcedefinition.apiextensions.k8s.io "appprojects.argoproj.io" deleted
- clusterrole.rbac.authorization.k8s.io "argocd-application-controller" deleted
- clusterrolebinding.rbac.authorization.k8s.io "argocd-application-controller" deleted
kubectl apply: exit status 1
To make things even easier, you could either add this information to the documentation or include the creation of the argocd namespace as part of the Skaffold configuration.
Overall, this is fantastic work and I'm excited to see this get merged in. Great job!
|
@drpaneas I added a |
Good thinking. The next step would be to automate the installation of Skaffold as a binary, but I don't think this is required for this PR. It's already good enough in my opinion. |
|
@blakepettersson is there anything else needed here or can we merge? I like using this workflow and I think others will benefit as well. It's not breaking anything (no regressions) just adding additional (ease) functionality. |
|
In the contributors meeting two weeks ago, @crenshaw-dev and @jannfis were concerned about having yet another way of running Argo CD in dev. Before merging the core committers would like to be aligned on how to run Argo in dev, and then commit to it. It could very well be Skaffold; I had promised to give a demo on one of these contributor meetings to show the other committers how nice it is to run but I haven't had the time. I could potentially give a demo tomorrow but I don't think it'll be too likely I'll have the time. If not then, I'll set time for next week's contributor meeting to give this a spin. |
blakepettersson
force-pushed
the
chore/add-skaffold-config
branch
from
2ec741f to
c9975db
Compare
blakepettersson
force-pushed
the
chore/add-skaffold-config
branch
2 times, most recently
from
4121a26 to
533824f
Compare
blakepettersson
force-pushed
the
chore/add-skaffold-config
branch
2 times, most recently
from
d6ef7bb to
23eac50
Compare
blakepettersson
force-pushed
the
chore/add-skaffold-config
branch
from
23eac50 to
31dcaa9
Compare
blakepettersson
force-pushed
the
chore/add-skaffold-config
branch
from
31dcaa9 to
c95fe13
Compare
blakepettersson
force-pushed
the
chore/add-skaffold-config
branch
2 times, most recently
from
b48f95a to
98dc48c
Compare
blakepettersson
force-pushed
the
chore/add-skaffold-config
branch
from
98dc48c to
f80c369
Compare
blakepettersson
force-pushed
the
chore/add-skaffold-config
branch
from
f80c369 to
8735f5b
Compare
blakepettersson
force-pushed
the
chore/add-skaffold-config
branch
2 times, most recently
from
7140df4 to
0d4c415
Compare
blakepettersson
force-pushed
the
chore/add-skaffold-config
branch
from
0d4c415 to
32cbf82
Compare
blakepettersson
force-pushed
the
chore/add-skaffold-config
branch
from
32cbf82 to
d8b8b54
Compare
blakepettersson
force-pushed
the
chore/add-skaffold-config
branch
2 times, most recently
from
cfd1938 to
d5794f8
Compare
blakepettersson
force-pushed
the
chore/add-skaffold-config
branch
from
d5794f8 to
993169f
Compare
blakepettersson
force-pushed
the
chore/add-skaffold-config
branch
from
94562a6 to
a93f05d
Compare
blakepettersson
force-pushed
the
chore/add-skaffold-config
branch
2 times, most recently
from
a97c383 to
732ac0e
Compare
This adds a Skaffold configuration for quickly standing up an Argo CD for development purposes. Signed-off-by: Blake Pettersson <[email protected]>
This makes sure the argocd-server is running in insecure mode locally. Signed-off-by: Blake Pettersson <[email protected]>
Co-authored-by: Panagiotis Georgiadis <[email protected]> Signed-off-by: Blake Pettersson <[email protected]>
Kustomize doesn't currently (or at least smoothly) create namespaces if one doesn't already exist, so let's add a make task to wrap `skaffold dev` along with creating a namespace if one doesn't already exist. Signed-off-by: Blake Pettersson <[email protected]>
Signed-off-by: Blake Pettersson <[email protected]>
Signed-off-by: Blake Pettersson <[email protected]>
Signed-off-by: Blake Pettersson <[email protected]>
blakepettersson
force-pushed
the
chore/add-skaffold-config
branch
from
732ac0e to
083ede0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a Skaffold configuration for quickly standing up an Argo CD for development purposes.
Signed-off-by: Blake Pettersson [email protected]
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
[ ] I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.[ ] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.