Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix get cluster #10856

Closed
wants to merge 1 commit into from
Closed

fix get cluster #10856

wants to merge 1 commit into from

Conversation

cleverhu
Copy link
Contributor

@cleverhu cleverhu commented Oct 8, 2022

Fixes: #10830
Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Fixes: argoproj#10830
Signed-off-by: cleverhu <[email protected]>
@codecov
Copy link

codecov bot commented Oct 8, 2022

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 45.65%. Comparing base (441b583) to head (c20fbf3).
Report is 2460 commits behind head on master.

Files Patch % Lines
cmd/argocd/commands/cluster.go 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10856      +/-   ##
==========================================
- Coverage   45.67%   45.65%   -0.02%     
==========================================
  Files         236      236              
  Lines       28698    28706       +8     
==========================================
  Hits        13107    13107              
- Misses      13799    13807       +8     
  Partials     1792     1792              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crenshaw-dev
Copy link
Member

Closing because I don't think there's a good way to fix this: #10830 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get Cluster returns PermissionDenied for non-existing clusters
2 participants