-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: improve argocd app delete #10160
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10160 +/- ##
==========================================
+ Coverage 45.92% 45.99% +0.06%
==========================================
Files 227 226 -1
Lines 27403 27408 +5
==========================================
+ Hits 12584 12605 +21
+ Misses 13110 13089 -21
- Partials 1709 1714 +5 ☔ View full report in Codecov by Sentry. |
On this note, I think a real improvement would be to refactor this code to use Line 115 in 7bd9e1e
|
There is an option of 'A' for confirmAnswer, which seems to be not so optimized: https://github.com/argoproj/argo-cd/blob/master/cmd/argocd/commands/app.go#L1104 |
ed5654c
to
0ca1aa8
Compare
Signed-off-by: xin.li <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Signed-off-by: xin.li <[email protected]>
Improve the confirmation method of argocd app delete, add general confirmation function
Checklist: