Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TOB-ARGO-006: Do not defer f.Close() #9963

Closed
crenshaw-dev opened this issue Jul 12, 2022 · 1 comment · Fixed by #10632
Closed

TOB-ARGO-006: Do not defer f.Close() #9963

crenshaw-dev opened this issue Jul 12, 2022 · 1 comment · Fixed by #10632
Assignees
@my-git9
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@crenshaw-dev
Copy link
Member

Summary

In places where we currently defer f.Close(), we should add logic to handle any error returned from f.Close().
@crenshaw-dev crenshaw-dev added enhancement New feature or request good first issue Good for newcomers GHC-2022 labels Jul 12, 2022
@my-git9
Copy link
Member

my-git9 commented Jul 13, 2022 •
edited
Loading

I can try, can you assign this issue to me? @crenshaw-dev

@my-git9 my-git9 mentioned this issue Jul 15, 2022
Merged
@crenshaw-dev crenshaw-dev changed the title Do not defer f.Close() TOB-ARGO-006: Do not defer f.Close() Jul 15, 2022
This was referenced Jul 16, 2022
Merged
Merged
crenshaw-dev pushed a commit that referenced this issue Jul 20, 2022
@my-git9
fix: Add logic to handle for f.Close() in util/localconfig/ (#9963)
b090103 
Signed-off-by: xin.li <[email protected]>
@my-git9 my-git9 mentioned this issue Jul 21, 2022
Merged
10 tasks
crenshaw-dev pushed a commit that referenced this issue Jul 25, 2022
@my-git9
fix: add logic to handle for f.Close() for util/io/files/tar.go (#9963)
7165786 
Signed-off-by: xin.li <[email protected]>
This was referenced Jul 28, 2022
Merged
Merged
crenshaw-dev pushed a commit that referenced this issue Jul 28, 2022
@my-git9
test: Add logic to handle for f.Close() for cmd/argocd/commands/admin (…
ea5063d 
…#9963) (#10074)

Signed-off-by: xin.li <[email protected]>
crenshaw-dev pushed a commit that referenced this issue Jul 28, 2022
@my-git9
fix: Add logic to handle for f.Close() for util/db (#9963) (#10127)
85b4dc3 
Signed-off-by: xin.li <[email protected]>
crenshaw-dev pushed a commit that referenced this issue Jul 28, 2022
@my-git9
fix: add logic to handle for f.Close() for util/gpg (#9963) (#10130)
57a407e 
Signed-off-by: xin.li <[email protected]>
@my-git9 my-git9 mentioned this issue Aug 1, 2022
Merged
10 tasks
crenshaw-dev pushed a commit that referenced this issue Aug 3, 2022
@my-git9
fix: Add logic to handle for file.Close() (#9963) (#10159)
9d21bb9 
Signed-off-by: xin.li <[email protected]>
ashutosh16 pushed a commit to ashutosh16/argo-cd that referenced this issue Aug 11, 2022
@my-git9 @ashutosh16
fix: Add logic to handle for file.Close() (argoproj#9963) (argoproj#1…
662ec70 
…0159)

Signed-off-by: xin.li <[email protected]>
crenshaw-dev pushed a commit that referenced this issue Aug 18, 2022
@my-git9
fix: Add logic to handle for fileHandle.Close() (#9963) (#10361)
519448e 
Signed-off-by: xin.li <[email protected]>

Signed-off-by: xin.li <[email protected]>
ciiay pushed a commit to ciiay/argo-cd that referenced this issue Aug 18, 2022
@my-git9 @ciiay
fix: Add logic to handle for fileHandle.Close() (argoproj#9963) (argo…
f82b1ae 
…proj#10361)

Signed-off-by: xin.li <[email protected]>

Signed-off-by: xin.li <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
crenshaw-dev added a commit that referenced this issue Aug 19, 2022
@ciiay @crenshaw-dev
@alexmt @my-git9 @daixijun @waltforme @jannfis
feat: make https repo credentials editable in the UI (#9108) (#9782)
f93d678 
* fix: missing actions (#10327) (#10359)

Signed-off-by: CI <[email protected]>

Signed-off-by: CI <[email protected]>
Signed-off-by: Yi Cai <[email protected]>

* chore: infer managed resources health from redis instead of storing it in CRD (#10191)

* chore: infer managed resources health from redis instead of storing it in CRD

Signed-off-by: Alexander Matyushentsev <[email protected]>

* apply reviewer notes

Signed-off-by: Alexander Matyushentsev <[email protected]>

Signed-off-by: Alexander Matyushentsev <[email protected]>
Signed-off-by: Yi Cai <[email protected]>

* fix: Add logic to handle for fileHandle.Close() (#9963) (#10361)

Signed-off-by: xin.li <[email protected]>

Signed-off-by: xin.li <[email protected]>
Signed-off-by: Yi Cai <[email protected]>

* docs: fix typo in upgrade notes (#10377)

Signed-off-by: Xijun Dai <[email protected]>

Signed-off-by: Xijun Dai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>

* fix: add space before prompt in CLI (#10362)

Signed-off-by: xin.li <[email protected]>

Signed-off-by: xin.li <[email protected]>
Signed-off-by: Yi Cai <[email protected]>

* docs: fix indentation of example AppProject in 'Sync Windows' documentation (#10388)

Signed-off-by: Yi Cai <[email protected]>

* fix: Correctly assume cluster-scoped resources to be self-referenced (#10390)

Signed-off-by: jannfis <[email protected]>

Signed-off-by: jannfis <[email protected]>
Signed-off-by: Yi Cai <[email protected]>

* ui-make-https-repo-credential-editable

Signed-off-by: ciiay <[email protected]>
Signed-off-by: Yi Cai <[email protected]>

* Minor format fix

Signed-off-by: ciiay <[email protected]>
Signed-off-by: Yi Cai <[email protected]>

* Minor fix for unclickable input field

Signed-off-by: ciiay <[email protected]>
Signed-off-by: Yi Cai <[email protected]>

* Updates for comments

Signed-off-by: ciiay <[email protected]>
Signed-off-by: Yi Cai <[email protected]>

* ui-make-https-repo-credential-editable

Signed-off-by: ciiay <[email protected]>
Signed-off-by: Yi Cai <[email protected]>

* Minor format fix

Signed-off-by: ciiay <[email protected]>
Signed-off-by: Yi Cai <[email protected]>

* Minor fix for unclickable input field

Signed-off-by: ciiay <[email protected]>
Signed-off-by: Yi Cai <[email protected]>

* Updates for comments

Signed-off-by: ciiay <[email protected]>
Signed-off-by: Yi Cai <[email protected]>

Signed-off-by: CI <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Alexander Matyushentsev <[email protected]>
Signed-off-by: xin.li <[email protected]>
Signed-off-by: Xijun Dai <[email protected]>
Signed-off-by: jannfis <[email protected]>
Signed-off-by: ciiay <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
Co-authored-by: Alexander Matyushentsev <[email protected]>
Co-authored-by: my-git9 <[email protected]>
Co-authored-by: Xijun Dai <[email protected]>
Co-authored-by: Jun Duan <[email protected]>
Co-authored-by: jannfis <[email protected]>
@my-git9 my-git9 mentioned this issue Sep 18, 2022
Merged
10 tasks
my-git9 added a commit to my-git9/argo-cd that referenced this issue Sep 18, 2022
@my-git9
fix(argoproj#9963):Add logic to handle for fileHandle.Close()
5251e9d 
Signed-off-by: xin.li <[email protected]>
Repository owner moved this from Todo to Done in Ada Logics audit follow-up Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@my-git9 my-git9

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Ada Logics audit follow-up
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(#9963):Add logic to handle for fileHandle.Close() my-git9/argo-cd
2 participants
@crenshaw-dev @my-git9