Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Allow individual application tiles to be selectable #4841

Closed
keithchong opened this issue Nov 16, 2020 · 2 comments · Fixed by #4851
Closed

test: Allow individual application tiles to be selectable #4841

keithchong opened this issue Nov 16, 2020 · 2 comments · Fixed by #4851
Assignees
Labels
component:ui User interfaces bugs and enhancements enhancement New feature or request

Comments

@keithchong
Copy link
Contributor

keithchong commented Nov 16, 2020

Summary

We need to add unique class values in order to use selectors to identify each application tile so that the UI test tool can uniquely identify each app easily, and perform actions on them.

Motivation

As it stands, it's likely not possible to uniquely identify each app.

Proposal

Add some unique test-specific identifier to the class attribute.

This is in addition to the changes made in to #4393 where we added test specific id attributes. With this, we will better handle more than one app in the application list view.

@keithchong keithchong added the enhancement New feature or request label Nov 16, 2020
@keithchong
Copy link
Contributor Author

Hi @alexmt , please assign this to me.

@jannfis jannfis added the component:ui User interfaces bugs and enhancements label Nov 16, 2020
keithchong added a commit to keithchong/argo-cd that referenced this issue Nov 17, 2020
@keithchong
Copy link
Contributor Author

The PR has been created. Here is a short demo selenium test script in action to take advantage of this change. It launches the ArgoCD Ui where 4 apps already exist. It clicks on the Delete button on the sockshop app. (Note, there are 4 app delete buttons in the tiles view). The confirmation window appears to confirm that the delete button has been pressed.

4841-ClickDeleteButtonOnAppTile.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:ui User interfaces bugs and enhancements enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants