Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Provide Add and Delete support in Sources tab for multi-source apps #18047

Closed
keithchong opened this issue May 1, 2024 · 0 comments · Fixed by #18804
Closed

UI: Provide Add and Delete support in Sources tab for multi-source apps #18047

keithchong opened this issue May 1, 2024 · 0 comments · Fixed by #18804
Assignees
@keithchong
Labels
component:ui User interfaces bugs and enhancements enhancement New feature or request multi-source-apps Bugs or enhancements related to multi-source Applications.

Comments

@keithchong
Copy link
Contributor

keithchong commented May 1, 2024 •
edited
Loading

Summary

Building on top of what was added for the Edit support in #17588, this enhancement covers the support for adding new sources and deleting existing sources from the Sources panel.

Motivation and Proposal

See proposal here, multiple-sources-for-applications-ui.md or original PR: #17108

Add Source button at the top, and Delete button on each source card:
ExpandedSourceShowingDeleteButton

Add Source panel (Has to be a sliding panel):
AddSourcePage

Pagination:
multisource-pagination

Delete warning:
DeleteWarning
@keithchong keithchong added enhancement New feature or request component:ui User interfaces bugs and enhancements labels May 1, 2024
@keithchong keithchong self-assigned this May 1, 2024
@ishitasequeira ishitasequeira added the multi-source-apps Bugs or enhancements related to multi-source Applications. label May 2, 2024
keithchong added a commit to keithchong/argo-cd that referenced this issue Jun 21, 2024
@keithchong
feat: Add/Delete support in Sources tab for multi-source apps (argopr…
8a83158 
…oj#18047)

Signed-off-by: Keith Chong <[email protected]>
keithchong added a commit to keithchong/argo-cd that referenced this issue Jun 21, 2024
@keithchong
feat: Add/Delete support in Sources tab for multi-source apps (argopr…
40a7eb2 
…oj#18047)

Signed-off-by: Keith Chong <[email protected]>
keithchong added a commit to keithchong/argo-cd that referenced this issue Jun 24, 2024
@keithchong
feat: Add/Delete support in Sources tab for multi-source apps(argopro…
e26131e 
…j#18047)

Signed-off-by: Keith Chong <[email protected]>
keithchong added a commit to keithchong/argo-cd that referenced this issue Jun 24, 2024
@keithchong
feat: Add/Delete support in Sources tab for multi-source apps(argopro…
da573af 
…j#18047)

Signed-off-by: Keith Chong <[email protected]>
keithchong added a commit to keithchong/argo-cd that referenced this issue Jun 24, 2024
@keithchong
feat: Add/Delete support in Sources tab for multi-source apps(argopro…
ffaaca8 
…j#18047)

Signed-off-by: Keith Chong <[email protected]>
@keithchong keithchong mentioned this issue Jun 24, 2024
Merged
14 tasks
keithchong added a commit to keithchong/argo-cd that referenced this issue Aug 21, 2024
@keithchong
feat: Add/Delete support for multi-source apps - rebase (argoproj#18047)
02671fd
keithchong added a commit to keithchong/argo-cd that referenced this issue Aug 21, 2024
@keithchong
feat: Add/Delete support for multi-source apps - rebase (argoproj#18047)
7d1dcc7 
Signed-off-by: Keith Chong <[email protected]>
keithchong added a commit to keithchong/argo-cd that referenced this issue Aug 26, 2024
@keithchong
feat: Add/Delete support in Sources tab for multi-source apps (argopr…
d2761a0 
…oj#18047)

Signed-off-by: Keith Chong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keithchong keithchong

Labels
component:ui User interfaces bugs and enhancements enhancement New feature or request multi-source-apps Bugs or enhancements related to multi-source Applications.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add/Delete support in Sources tab for multi-source apps (#18047) keithchong/argo-cd
2 participants
@keithchong @ishitasequeira