Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Support multiple sources for an Application in the UI #17106

Closed
keithchong opened this issue Feb 6, 2024 · 0 comments · Fixed by #17108
Closed

Proposal: Support multiple sources for an Application in the UI #17106

keithchong opened this issue Feb 6, 2024 · 0 comments · Fixed by #17108
Assignees
Labels
enhancement New feature or request

Comments

@keithchong
Copy link
Contributor

keithchong commented Feb 6, 2024

Summary

The core proposal for supporting multiple sources for applications does not include the design proposal of the UI. This enhancement proposal covers the UI changes for supporting multiple sources.

See related:
The proposal issue: #677
The core proposal PR: #8322
The implementation: #10432

Motivation

The above implementation tolerates applications with multiple sources. The UI displays information only for the first source. There are other restrictions and limitations that make multiple-source apps less than first class citizens in the UI. There are scenarios where user input can be lost.

A comprehensive PR already submitted is to address the issue in History and Rollback, which is just one piece of the overall puzzle. See #14124
See comment: #10432 (comment)

A proposal is likely needed to cover all the main changes in the UI.

Proposal

Proposal to be included

@keithchong keithchong added the enhancement New feature or request label Feb 6, 2024
@keithchong keithchong self-assigned this Feb 6, 2024
keithchong added a commit to keithchong/argo-cd that referenced this issue Feb 6, 2024
keithchong added a commit to keithchong/argo-cd that referenced this issue Feb 7, 2024
crenshaw-dev pushed a commit that referenced this issue Apr 8, 2024
* docs: Proposal to support multi-source apps in the UI (#17106)

Signed-off-by: Keith Chong <[email protected]>

* Update docs/proposals/multiple-sources-for-applications-ui.md

Co-authored-by: Josh Soref <[email protected]>
Signed-off-by: Keith Chong <[email protected]>

* Update docs/proposals/multiple-sources-for-applications-ui.md

Co-authored-by: Josh Soref <[email protected]>
Signed-off-by: Keith Chong <[email protected]>

* Update docs/proposals/multiple-sources-for-applications-ui.md

Co-authored-by: Josh Soref <[email protected]>
Signed-off-by: Keith Chong <[email protected]>

* Update docs/proposals/multiple-sources-for-applications-ui.md

Co-authored-by: Josh Soref <[email protected]>
Signed-off-by: Keith Chong <[email protected]>

* Update docs/proposals/multiple-sources-for-applications-ui.md

Co-authored-by: Josh Soref <[email protected]>
Signed-off-by: Keith Chong <[email protected]>

* Update docs/proposals/multiple-sources-for-applications-ui.md

Co-authored-by: Josh Soref <[email protected]>
Signed-off-by: Keith Chong <[email protected]>

* Update docs/proposals/multiple-sources-for-applications-ui.md

Co-authored-by: Josh Soref <[email protected]>
Signed-off-by: Keith Chong <[email protected]>

* Minor edits

Signed-off-by: Keith Chong <[email protected]>

---------

Signed-off-by: Keith Chong <[email protected]>
Co-authored-by: Josh Soref <[email protected]>
mkieweg pushed a commit to mkieweg/argo-cd that referenced this issue Jun 11, 2024
argoproj#17108)

* docs: Proposal to support multi-source apps in the UI (argoproj#17106)

Signed-off-by: Keith Chong <[email protected]>

* Update docs/proposals/multiple-sources-for-applications-ui.md

Co-authored-by: Josh Soref <[email protected]>
Signed-off-by: Keith Chong <[email protected]>

* Update docs/proposals/multiple-sources-for-applications-ui.md

Co-authored-by: Josh Soref <[email protected]>
Signed-off-by: Keith Chong <[email protected]>

* Update docs/proposals/multiple-sources-for-applications-ui.md

Co-authored-by: Josh Soref <[email protected]>
Signed-off-by: Keith Chong <[email protected]>

* Update docs/proposals/multiple-sources-for-applications-ui.md

Co-authored-by: Josh Soref <[email protected]>
Signed-off-by: Keith Chong <[email protected]>

* Update docs/proposals/multiple-sources-for-applications-ui.md

Co-authored-by: Josh Soref <[email protected]>
Signed-off-by: Keith Chong <[email protected]>

* Update docs/proposals/multiple-sources-for-applications-ui.md

Co-authored-by: Josh Soref <[email protected]>
Signed-off-by: Keith Chong <[email protected]>

* Update docs/proposals/multiple-sources-for-applications-ui.md

Co-authored-by: Josh Soref <[email protected]>
Signed-off-by: Keith Chong <[email protected]>

* Minor edits

Signed-off-by: Keith Chong <[email protected]>

---------

Signed-off-by: Keith Chong <[email protected]>
Co-authored-by: Josh Soref <[email protected]>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this issue Jun 16, 2024
argoproj#17108)

* docs: Proposal to support multi-source apps in the UI (argoproj#17106)

Signed-off-by: Keith Chong <[email protected]>

* Update docs/proposals/multiple-sources-for-applications-ui.md

Co-authored-by: Josh Soref <[email protected]>
Signed-off-by: Keith Chong <[email protected]>

* Update docs/proposals/multiple-sources-for-applications-ui.md

Co-authored-by: Josh Soref <[email protected]>
Signed-off-by: Keith Chong <[email protected]>

* Update docs/proposals/multiple-sources-for-applications-ui.md

Co-authored-by: Josh Soref <[email protected]>
Signed-off-by: Keith Chong <[email protected]>

* Update docs/proposals/multiple-sources-for-applications-ui.md

Co-authored-by: Josh Soref <[email protected]>
Signed-off-by: Keith Chong <[email protected]>

* Update docs/proposals/multiple-sources-for-applications-ui.md

Co-authored-by: Josh Soref <[email protected]>
Signed-off-by: Keith Chong <[email protected]>

* Update docs/proposals/multiple-sources-for-applications-ui.md

Co-authored-by: Josh Soref <[email protected]>
Signed-off-by: Keith Chong <[email protected]>

* Update docs/proposals/multiple-sources-for-applications-ui.md

Co-authored-by: Josh Soref <[email protected]>
Signed-off-by: Keith Chong <[email protected]>

* Minor edits

Signed-off-by: Keith Chong <[email protected]>

---------

Signed-off-by: Keith Chong <[email protected]>
Co-authored-by: Josh Soref <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant