Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Follow logs, automatically showing new logs lines" and "Automatically scroll to the bottom when new content appears" not working #15848

Closed
3 tasks
kaushikvira opened this issue Oct 6, 2023 · 4 comments
Labels
bug Something isn't working component:ui User interfaces bugs and enhancements regression Bug is a regression, should be handled with high priority
Milestone

Comments

@kaushikvira
Copy link

kaushikvira commented Oct 6, 2023

Checklist:

  • I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
  • I've included steps to reproduce the bug.
  • I've pasted the output of argocd version.

"Follow logs, automatically showing new logs lines" and "Automatically scroll to the bottom when new content appears" not working in 2.9.0-rc2 but works in 2.8.2

image

Here is the full discussion on the issue

To Reproduce
Click on any Pod Got to Logs and Click the 2 button shown in the above screenshot.

1

Expected behavior

Log scroll to the bottom the screen to move as a new log appears

Screenshots
image

Version
2.9.0-rc2

Paste the output from `argocd version` here.

Logs

Paste any relevant application logs here.
@kaushikvira kaushikvira added the bug Something isn't working label Oct 6, 2023
@crenshaw-dev crenshaw-dev added regression Bug is a regression, should be handled with high priority component:ui User interfaces bugs and enhancements labels Oct 6, 2023
@crenshaw-dev crenshaw-dev added this to the v2.9 milestone Oct 13, 2023
@ashutosh16
Copy link
Contributor

/assign

@keithchong
Copy link
Contributor

Hi @crenshaw-dev @ashutosh16 , I went back to the original commit that introduced the new button (to automatically scroll to the bottom) but I don't see any difference in behavior. It's possible in 2.8.2 the log view always scrolled to the bottom, and that's why we needed the buttons in the first place, so that you are still able to view the contents from where you were.

@keithchong
Copy link
Contributor

keithchong commented Oct 24, 2023

I see the correct behavior now. @ciiay , what do you think about this? I see the issue after this change was introduced: #15506

Without the 15506 change, when you click on the "Automatically scroll to the bottom..." button, it jumps to the bottom of the log and it follows. With the 15506 change, it does not, and it does not follow when there are new lines.

@ciiay
Copy link
Contributor

ciiay commented Oct 24, 2023

I'll raise a PR to fix this issue.

crenshaw-dev pushed a commit that referenced this issue Oct 25, 2023
* Fixed log button behaviors

Signed-off-by: Yi Cai <[email protected]>

* Fixed lint-ui issues

Signed-off-by: Yi Cai <[email protected]>

---------

Signed-off-by: Yi Cai <[email protected]>
gcp-cherry-pick-bot bot pushed a commit that referenced this issue Oct 25, 2023
* Fixed log button behaviors

Signed-off-by: Yi Cai <[email protected]>

* Fixed lint-ui issues

Signed-off-by: Yi Cai <[email protected]>

---------

Signed-off-by: Yi Cai <[email protected]>
crenshaw-dev pushed a commit that referenced this issue Oct 25, 2023
* Fixed log button behaviors



* Fixed lint-ui issues



---------

Signed-off-by: Yi Cai <[email protected]>
Co-authored-by: Yi Cai <[email protected]>
ymktmk pushed a commit to ymktmk/argo-cd that referenced this issue Oct 29, 2023
* Fixed log button behaviors

Signed-off-by: Yi Cai <[email protected]>

* Fixed lint-ui issues

Signed-off-by: Yi Cai <[email protected]>

---------

Signed-off-by: Yi Cai <[email protected]>
jmilic1 pushed a commit to jmilic1/argo-cd that referenced this issue Nov 13, 2023
* Fixed log button behaviors

Signed-off-by: Yi Cai <[email protected]>

* Fixed lint-ui issues

Signed-off-by: Yi Cai <[email protected]>

---------

Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: jmilic1 <[email protected]>
vladfr pushed a commit to vladfr/argo-cd that referenced this issue Dec 13, 2023
* Fixed log button behaviors

Signed-off-by: Yi Cai <[email protected]>

* Fixed lint-ui issues

Signed-off-by: Yi Cai <[email protected]>

---------

Signed-off-by: Yi Cai <[email protected]>
tesla59 pushed a commit to tesla59/argo-cd that referenced this issue Dec 16, 2023
* Fixed log button behaviors

Signed-off-by: Yi Cai <[email protected]>

* Fixed lint-ui issues

Signed-off-by: Yi Cai <[email protected]>

---------

Signed-off-by: Yi Cai <[email protected]>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this issue Jun 16, 2024
* Fixed log button behaviors

Signed-off-by: Yi Cai <[email protected]>

* Fixed lint-ui issues

Signed-off-by: Yi Cai <[email protected]>

---------

Signed-off-by: Yi Cai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component:ui User interfaces bugs and enhancements regression Bug is a regression, should be handled with high priority
Projects
None yet
Development

No branches or pull requests

5 participants