-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Follow logs, automatically showing new logs lines" and "Automatically scroll to the bottom when new content appears" not working #15848
Comments
/assign |
Hi @crenshaw-dev @ashutosh16 , I went back to the original commit that introduced the new button (to automatically scroll to the bottom) but I don't see any difference in behavior. It's possible in 2.8.2 the log view always scrolled to the bottom, and that's why we needed the buttons in the first place, so that you are still able to view the contents from where you were. |
I see the correct behavior now. @ciiay , what do you think about this? I see the issue after this change was introduced: #15506 Without the 15506 change, when you click on the "Automatically scroll to the bottom..." button, it jumps to the bottom of the log and it follows. With the 15506 change, it does not, and it does not follow when there are new lines. |
I'll raise a PR to fix this issue. |
* Fixed log button behaviors Signed-off-by: Yi Cai <[email protected]> * Fixed lint-ui issues Signed-off-by: Yi Cai <[email protected]> --------- Signed-off-by: Yi Cai <[email protected]>
* Fixed log button behaviors Signed-off-by: Yi Cai <[email protected]> * Fixed lint-ui issues Signed-off-by: Yi Cai <[email protected]> --------- Signed-off-by: Yi Cai <[email protected]>
* Fixed log button behaviors * Fixed lint-ui issues --------- Signed-off-by: Yi Cai <[email protected]> Co-authored-by: Yi Cai <[email protected]>
* Fixed log button behaviors Signed-off-by: Yi Cai <[email protected]> * Fixed lint-ui issues Signed-off-by: Yi Cai <[email protected]> --------- Signed-off-by: Yi Cai <[email protected]>
* Fixed log button behaviors Signed-off-by: Yi Cai <[email protected]> * Fixed lint-ui issues Signed-off-by: Yi Cai <[email protected]> --------- Signed-off-by: Yi Cai <[email protected]> Signed-off-by: jmilic1 <[email protected]>
* Fixed log button behaviors Signed-off-by: Yi Cai <[email protected]> * Fixed lint-ui issues Signed-off-by: Yi Cai <[email protected]> --------- Signed-off-by: Yi Cai <[email protected]>
* Fixed log button behaviors Signed-off-by: Yi Cai <[email protected]> * Fixed lint-ui issues Signed-off-by: Yi Cai <[email protected]> --------- Signed-off-by: Yi Cai <[email protected]>
* Fixed log button behaviors Signed-off-by: Yi Cai <[email protected]> * Fixed lint-ui issues Signed-off-by: Yi Cai <[email protected]> --------- Signed-off-by: Yi Cai <[email protected]>
Checklist:
argocd version
."Follow logs, automatically showing new logs lines" and "Automatically scroll to the bottom when new content appears" not working in 2.9.0-rc2 but works in 2.8.2
Here is the full discussion on the issue
To Reproduce
Click on any Pod Got to Logs and Click the 2 button shown in the above screenshot.
1
Expected behavior
Log scroll to the bottom the screen to move as a new log appears
Screenshots
Version
2.9.0-rc2
Paste the output from `argocd version` here.
Logs
The text was updated successfully, but these errors were encountered: