"Create Job" action doesn't add jobTemplate.spec from CronJob to created Job's spec

[kodzimo]

Checklist:

• I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
• I've included steps to reproduce the bug.
• I've pasted the output of argocd version.

Describe the bug

As expected from the action, it should create a Job from CronJob as it does kubectl create job --from=<CRON_JOB_NAME> command. But all of a sudden I noticed, that Jobs, created by the action, don't have appropriate jobTemplate.spec, while Jobs, created by kubectl create job --from=<CRON_JOB_NAME> - do have.
In my example, I was trying to set ttlSecondsAfterFinished to jobTemplate.spec, and noticed unexpected behavior. Maybe the reason is the 50th sting in action.lua file

To Reproduce

Add ttlSecondsAfterFinished to CronJob's jobTemplate.spec and trigger the action "Create Job". You will see no ttlSecondsAfterFinished in created Job's spec.

Expected behavior

Created by the action "Create Job" Job should be the same as created by kubectl create job --from=<CRON_JOB_NAME>

Screenshots

No screenshots attached.

Version

v2.8.0+804d4b8

Logs

No logs added.

[SergeyLadutko]

Me too

[crenshaw-dev]

Would either of you be up for modifying https://github.com/argoproj/argo-cd/blob/master/resource_customizations/batch/CronJob/actions/create-job/action.lua and submitting a PR? Should be pretty straightforward to set up a new test for the problematic case.

[kodzimo]

Would either of you be up for modifying https://github.com/argoproj/argo-cd/blob/master/resource_customizations/batch/CronJob/actions/create-job/action.lua and submitting a PR? Should be pretty straightforward to set up a new test for the problematic case.

Yes, I'll try to contribute appropriate modification.

[kodzimo]

@crenshaw-dev modification to lua script is done. But I'm little confused 'bout tests: does it really should be the new test?
Seems like TestLuaResourceActionsScript test from custom_actions_test.go has necessary functionality, but it works not as expected (again 😅). Is it correct to expect (according to action_test.yaml), that in TestLuaResourceActionsScript job.yaml must be compared to generated by lua script from cronjob.yaml Job's manifest ?

[SergeyLadutko]

@crenshaw-dev

@crenshaw-dev modification to lua script is done. But I'm little confused 'bout tests: does it really should be the new test? Seems like TestLuaResourceActionsScript test from custom_actions_test.go has necessary functionality, but it works not as expected (again 😅). Is it correct to expect (according to action_test.yaml), that in TestLuaResourceActionsScript job.yaml must be compared to generated by lua script from cronjob.yaml Job's manifest ?

Can you answer the question above?

[SergeyLadutko]

@crenshaw-dev
I think this one is ready for review

[crenshaw-dev]

Hey! Sorry I missed your question. Yep, I think you're correct. Just gotta have input and then match output against the expected job.