Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCM Provider: Use Gitlab project topics #13169

Closed
3 tasks done
tillepille opened this issue Apr 9, 2023 · 0 comments · Fixed by #13170
Closed
3 tasks done

SCM Provider: Use Gitlab project topics #13169

tillepille opened this issue Apr 9, 2023 · 0 comments · Fixed by #13170
Labels
bug Something isn't working

Comments

@tillepille
Copy link
Contributor

tillepille commented Apr 9, 2023 •
edited
Loading

Checklist:

  • I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
  • I've included steps to reproduce the bug.
  • I've pasted the output of argocd version.

Describe the bug

Gitlab deprecated tags for projects.

(Deprecated in GitLab 14.0) The list of tags for a project; put array of tags, that should be finally assigned to a project. Use topics instead.

For compatibility reasons they decided to alias both fields, see the MR: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/60405

To Reproduce

  1. add a topic to your project
  2. call API gitlab.com/api/v4/projects/<PROJECT_ID>
...
  "tag_list": [
    "mytopic"
  ],
  "topics": [
    "mytopic"
  ],
...

Expected behavior

the correct field is used.

Screenshots

Version

Paste the output from `argocd version` here.

Logs

Paste any relevant application logs here.
@tillepille tillepille added the bug Something isn't working label Apr 9, 2023
@tillepille tillepille mentioned this issue Apr 9, 2023
Merged
13 tasks
ishitasequeira pushed a commit that referenced this issue Nov 20, 2023
@tillepille
fix(appset): use topics for Gitlab SCM Provider (#13169) (#13170)
b2a52de 
* fix(scm gitlab): use project topics instead of tags

Signed-off-by: tillepille <[email protected]>

* feat(scm gitlab): add testcase for labels

Signed-off-by: tillepille <[email protected]>

fix test

Signed-off-by: tillepille <[email protected]>

* feat(scm gitlab): update docs for gitlab filtering

Signed-off-by: tillepille <[email protected]>

* feat(scm gitlab): add fallback for old gitlab versions

Signed-off-by: tillepille <[email protected]>

---------

Signed-off-by: tillepille <[email protected]>
alexymantha pushed a commit to alexymantha/argo-cd that referenced this issue Nov 22, 2023
@tillepille @alexymantha
fix(appset): use topics for Gitlab SCM Provider (argoproj#13169) (arg…
964d8ec 
…oproj#13170)

* fix(scm gitlab): use project topics instead of tags

Signed-off-by: tillepille <[email protected]>

* feat(scm gitlab): add testcase for labels

Signed-off-by: tillepille <[email protected]>

fix test

Signed-off-by: tillepille <[email protected]>

* feat(scm gitlab): update docs for gitlab filtering

Signed-off-by: tillepille <[email protected]>

* feat(scm gitlab): add fallback for old gitlab versions

Signed-off-by: tillepille <[email protected]>

---------

Signed-off-by: tillepille <[email protected]>
vladfr pushed a commit to vladfr/argo-cd that referenced this issue Dec 13, 2023
@tillepille @vladfr
fix(appset): use topics for Gitlab SCM Provider (argoproj#13169) (arg…
ec4300b 
…oproj#13170)

* fix(scm gitlab): use project topics instead of tags

Signed-off-by: tillepille <[email protected]>

* feat(scm gitlab): add testcase for labels

Signed-off-by: tillepille <[email protected]>

fix test

Signed-off-by: tillepille <[email protected]>

* feat(scm gitlab): update docs for gitlab filtering

Signed-off-by: tillepille <[email protected]>

* feat(scm gitlab): add fallback for old gitlab versions

Signed-off-by: tillepille <[email protected]>

---------

Signed-off-by: tillepille <[email protected]>
tesla59 pushed a commit to tesla59/argo-cd that referenced this issue Dec 16, 2023
@tillepille @tesla59
fix(appset): use topics for Gitlab SCM Provider (argoproj#13169) (arg…
b91fb55 
…oproj#13170)

* fix(scm gitlab): use project topics instead of tags

Signed-off-by: tillepille <[email protected]>

* feat(scm gitlab): add testcase for labels

Signed-off-by: tillepille <[email protected]>

fix test

Signed-off-by: tillepille <[email protected]>

* feat(scm gitlab): update docs for gitlab filtering

Signed-off-by: tillepille <[email protected]>

* feat(scm gitlab): add fallback for old gitlab versions

Signed-off-by: tillepille <[email protected]>

---------

Signed-off-by: tillepille <[email protected]>
lyda pushed a commit to lyda/argo-cd that referenced this issue Mar 28, 2024
@tillepille @lyda
fix(appset): use topics for Gitlab SCM Provider (argoproj#13169) (arg…
a129cd6 
…oproj#13170)

* fix(scm gitlab): use project topics instead of tags

Signed-off-by: tillepille <[email protected]>

* feat(scm gitlab): add testcase for labels

Signed-off-by: tillepille <[email protected]>

fix test

Signed-off-by: tillepille <[email protected]>

* feat(scm gitlab): update docs for gitlab filtering

Signed-off-by: tillepille <[email protected]>

* feat(scm gitlab): add fallback for old gitlab versions

Signed-off-by: tillepille <[email protected]>

---------

Signed-off-by: tillepille <[email protected]>
Signed-off-by: Kevin Lyda <[email protected]>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this issue Jun 16, 2024
@tillepille @Hariharasuthan99
fix(appset): use topics for Gitlab SCM Provider (argoproj#13169) (arg…
e1edcd3 
…oproj#13170)

* fix(scm gitlab): use project topics instead of tags

Signed-off-by: tillepille <[email protected]>

* feat(scm gitlab): add testcase for labels

Signed-off-by: tillepille <[email protected]>

fix test

Signed-off-by: tillepille <[email protected]>

* feat(scm gitlab): update docs for gitlab filtering

Signed-off-by: tillepille <[email protected]>

* feat(scm gitlab): add fallback for old gitlab versions

Signed-off-by: tillepille <[email protected]>

---------

Signed-off-by: tillepille <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(appset): use topics for Gitlab SCM Provider (#13169)
1 participant
@tillepille