Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deletion prevention #12470

Closed
ofirshtrull opened this issue Feb 15, 2023 · 1 comment
Closed

deletion prevention #12470

ofirshtrull opened this issue Feb 15, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@ofirshtrull
Copy link

Summary

by mistake last week I almost made a change that could have deleted a full applicationset in my prod
(Luckey it was stoped in pr)
I think maybe we a new annotation can be added to applicationsets and applications that if there it will prevent a deletion on the argo resource

Motivation

such as

apiVersion: argoproj.io/v1alpha1
kind: ApplicationSet
metadata:
  name: test
  namespace: argocd
  label: 
    deletion_prevention: true
spec:
  generators:

or don't have two ApplicationSet/Applications with the same name and having the new one by mistake delete the old one

@ofirshtrull ofirshtrull added the enhancement New feature or request label Feb 15, 2023
@crenshaw-dev
Copy link
Member

I think this is a duplicate of #11073

Let me know if I'm wrong!

@crenshaw-dev crenshaw-dev closed this as not planned Won't fix, can't repro, duplicate, stale Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants