Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the Applicationset policy to be set on ApplicationSet object instead of global flag #11073

Closed
jdomag opened this issue Oct 26, 2022 · 1 comment · Fixed by #11462
Closed
Labels
enhancement New feature or request

Comments

@jdomag
Copy link

jdomag commented Oct 26, 2022

Summary

The policy is set per whole controller, while it should be set per ApplicationSet object.

Motivation

We use staging and dev environments on the same k8s cluster separated by namespace. For staging it's not allowed to override Application parameters and applicationset policy=create-update should be applied. For dev namespaces it's totally fine to edit application parameters from cli or gui - for example to switch target branch to simplify testing of changes in helm charts. In that case we need policy=create-only to be set.

Proposal

default policy field can be overridden by spec of ApplicationSet object.

@jdomag jdomag added the enhancement New feature or request label Oct 26, 2022
@nhuray
Copy link

nhuray commented Nov 24, 2022

It's definitely a feature all ArgoCD users would benefit. At the moment the workaround is to deploy 2 ArgoCD instances.

@crenshaw-dev crenshaw-dev changed the title Applicationset policy is set on ApplicationSet object instead of global flag Allow the Applicationset policy to be set on ApplicationSet object instead of global flag Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants