Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support migration to Google Analytics 4 (GA4) - upgrade mkdocs-material to v7.1.8+ #10850

Closed
2 tasks
chalin opened this issue Oct 7, 2022 · 6 comments · Fixed by #11248
Closed
2 tasks

Support migration to Google Analytics 4 (GA4) - upgrade mkdocs-material to v7.1.8+ #10850

chalin opened this issue Oct 7, 2022 · 6 comments · Fixed by #11248

Comments

@chalin
Copy link
Contributor

chalin commented Oct 7, 2022


  • Upgrade mkdocs-material to v7.1.8+
  • If it turns out that GA4 doesn't support the equivalent of UA search-and-replace filters, then a change in path of the published doc pages for this site might be in order. I'm still investigating this. Until a solution is found, we probably shouldn't register this site's page view with the unified GA4 web site tag.

/cc @alexmt @alexec

@chalin
Copy link
Contributor Author

chalin commented Oct 7, 2022

@chalin
Copy link
Contributor Author

chalin commented Nov 3, 2022

@chalin
Copy link
Contributor Author

chalin commented Nov 9, 2022

Friendly ping @alexmt et al. Can someone update mkdocs-material to v7.1.8+? Also see the issues listed in the comment above. Thanks.

@chalin
Copy link
Contributor Author

chalin commented Nov 9, 2022

Btw, the Argo workflows website is built using v8.x of mkdocs_material: https://github.com/argoproj/argo-workflows/blob/1487bbc197a54a2e8caae4205aa98283583956f1/Makefile#L636-L637. If this repo could update to v8 as well, that would be grand, but I understand that that might be too big of a version jump (due to the possible breaking changes that might need to be addresses due to a major version increment).

@alexef
Copy link
Member

alexef commented Nov 9, 2022

@chalin see: #11248 as a starting point

@chalin
Copy link
Contributor Author

chalin commented Nov 9, 2022

Great, thanks @alexef! I'll track that PR.

crenshaw-dev pushed a commit that referenced this issue Nov 14, 2022
)

* fix docs build. prepare for google analytics v4

Signed-off-by: Alex Eftimie <[email protected]>

* fix build

Signed-off-by: Alex Eftimie <[email protected]>

* fix build codegen check

Signed-off-by: Alex Eftimie <[email protected]>

Signed-off-by: Alex Eftimie <[email protected]>
alexmt pushed a commit to alexmt/argo-cd that referenced this issue Nov 17, 2022
…) (argoproj#11248)

* fix docs build. prepare for google analytics v4

Signed-off-by: Alex Eftimie <[email protected]>

* fix build

Signed-off-by: Alex Eftimie <[email protected]>

* fix build codegen check

Signed-off-by: Alex Eftimie <[email protected]>

Signed-off-by: Alex Eftimie <[email protected]>
ashutosh16 pushed a commit to ashutosh16/argo-cd that referenced this issue Nov 23, 2022
…) (argoproj#11248)

* fix docs build. prepare for google analytics v4

Signed-off-by: Alex Eftimie <[email protected]>

* fix build

Signed-off-by: Alex Eftimie <[email protected]>

* fix build codegen check

Signed-off-by: Alex Eftimie <[email protected]>

Signed-off-by: Alex Eftimie <[email protected]>
emirot pushed a commit to emirot/argo-cd that referenced this issue Jan 27, 2023
…) (argoproj#11248)

* fix docs build. prepare for google analytics v4

Signed-off-by: Alex Eftimie <[email protected]>

* fix build

Signed-off-by: Alex Eftimie <[email protected]>

* fix build codegen check

Signed-off-by: Alex Eftimie <[email protected]>

Signed-off-by: Alex Eftimie <[email protected]>
Signed-off-by: emirot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants