Skip to content

Commit

Permalink
corrected few comments
Browse files Browse the repository at this point in the history
Signed-off-by: Prune <[email protected]>
  • Loading branch information
prune998 committed Aug 9, 2023
1 parent 13b9370 commit e5c6607
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 6 deletions.
3 changes: 1 addition & 2 deletions applicationset/services/scm_provider/gitlab_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ import (

func gitlabMockHandler(t *testing.T) func(http.ResponseWriter, *http.Request) {
return func(w http.ResponseWriter, r *http.Request) {
t.Log(r.RequestURI)
w.Header().Set("Content-Type", "application/json")
switch r.RequestURI {
case "/api/v4":
Expand Down Expand Up @@ -1136,7 +1135,7 @@ func TestGitlabListRepos(t *testing.T) {
if c.includeSubgroups || c.includeSharedProjects {
assert.Equal(t, 2, len(uniqueRepos))
}
// In cas we filter on the topic, ensure we got only one repo returned
// In case we filter on the topic, ensure we got only one repo returned
if c.topic != "" {
assert.Equal(t, 1, len(uniqueRepos))
}
Expand Down
2 changes: 1 addition & 1 deletion assets/swagger.json
Original file line number Diff line number Diff line change
Expand Up @@ -8695,7 +8695,7 @@
"$ref": "#/definitions/v1alpha1SecretRef"
},
"topic": {
"description": "Filter repos list based on Gitlab Topic (tag).",
"description": "Filter repos list based on Gitlab Topic.",
"type": "string"
}
}
Expand Down
2 changes: 1 addition & 1 deletion pkg/apis/application/v1alpha1/applicationset_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -443,7 +443,7 @@ type SCMProviderGeneratorGitlab struct {
Insecure bool `json:"insecure,omitempty" protobuf:"varint,6,opt,name=insecure"`
// When recursing through subgroups, also include shared Projects (true) or scan only the subgroups under same path (false). Defaults to "true"
IncludeSharedProjects *bool `json:"includeSharedProjects,omitempty" protobuf:"varint,7,opt,name=includeSharedProjects"`
// Filter repos list based on Gitlab Topic (tag).
// Filter repos list based on Gitlab Topic.
Topic string `json:"topic,omitempty" protobuf:"bytes,8,opt,name=topic"`
}

Expand Down
2 changes: 1 addition & 1 deletion pkg/apis/application/v1alpha1/generated.proto

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pkg/apis/application/v1alpha1/openapi_generated.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit e5c6607

Please sign in to comment.