chore: native client mock should be generated with go gen (#17864)

* fix: native client mock should be generated with go gen Signed-off-by: pashakostohrys <[email protected]> * fix: native client mock should be generated with go gen Signed-off-by: pashakostohrys <[email protected]> * fix: native client mock should be generated with go gen Signed-off-by: pashakostohrys <[email protected]> * adopt repository_test.go to new helm mock client Signed-off-by: pashakostohrys <[email protected]> --------- Signed-off-by: pashakostohrys <[email protected]>
argoproj · Apr 16, 2024 · 48b636e · 48b636e
1 parent e12fae8
commit 48b636e
Show file tree

Hide file tree

Showing 3 changed files with 52 additions and 23 deletions.
diff --git a/reposerver/repository/repository_test.go b/reposerver/repository/repository_test.go
@@ -123,8 +123,8 @@ func newServiceWithMocks(t *testing.T, root string, signed bool) (*Service, *git
 			chart:    {{Version: "1.0.0"}, {Version: version}},
 			oobChart: {{Version: "1.0.0"}, {Version: version}},
 		}}, nil)
-		helmClient.On("ExtractChart", chart, version).Return("./testdata/my-chart", io.NopCloser, nil)
-		helmClient.On("ExtractChart", oobChart, version).Return("./testdata2/out-of-bounds-chart", io.NopCloser, nil)
+		helmClient.On("ExtractChart", chart, version, false, int64(0), false).Return("./testdata/my-chart", io.NopCloser, nil)
+		helmClient.On("ExtractChart", oobChart, version, false, int64(0), false).Return("./testdata2/out-of-bounds-chart", io.NopCloser, nil)
 		helmClient.On("CleanChartCache", chart, version).Return(nil)
 		helmClient.On("CleanChartCache", oobChart, version).Return(nil)
 		helmClient.On("DependencyBuild").Return(nil)

diff --git a/util/helm/client.go b/util/helm/client.go
@@ -32,6 +32,8 @@ import (
 	"github.com/argoproj/argo-cd/v2/util/proxy"
 )
 
+//go:generate go run github.com/vektra/mockery/[email protected] --name=Client
+
 var (
 	globalLock = sync.NewKeyLock()
 	indexLock  = sync.NewKeyLock()

diff --git a/util/helm/mocks/Client.go b/util/helm/mocks/Client.go