-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update stale config #423
Conversation
Details: - Action update v8 -> v9 - Increase stale days 14 -> 60 - Do not stale issues with labels "on-hold", "pinned" or "good first issue" Signed-off-by: Marco Maurer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This issue has been automatically marked as stale because it has not had | ||
recent activity. It will be closed if no further activity occurs. Thank you | ||
for your contributions. | ||
exempt-issue-labels: "on-hold,pinned,good first issue" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mkilchhofer Just a heads-up, changing this from any-of-issue-labels
to exempt-issue-labels
(or changing the values - haven't looked at the diff between v8 and v9 of the action) seems to have flooded my notifications as all (?) existing issues - most, if not all, of which are valid have now been marked as stale. Might want to consider changing it back or, going through the issue list and setting the new tags where you think it's appropriate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep I was aware of this :) do you think it makes sense to keep every issue open? I thought it is good to close old stuff where we do not get a "not stale" comment from the issue creator.
Do you have another opinion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, maybe too aggressive at this point. There are definitely issues that are still valid - I just haven't had the time to look at them or via the previous classification was hoping someone else would pick them up.
Details: