Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get tests working on M1/ARM 64 #222

Merged
merged 1 commit into from
Dec 13, 2022

Conversation

jdmaguire
Copy link
Contributor

When I was trying to run the tests locally, they were failing to compile on master. Why? I am on a Mac M1 / Arm64 computer. One of the transitive dependencies, bigftt, is five years old and lacks arm64 support. Using a replace to get a newer version does allow me to run the tests.

If you are curious about the error:

make testacc_prepare_env && make testacc && make testacc_clean_env
....                                               
sh scripts/testacc.sh
# github.com/remyoudompheng/bigfft
../../../../pkg/mod/github.com/remyoudompheng/[email protected]/arith_decl.go:10:6: missing function body
../../../../pkg/mod/github.com/remyoudompheng/[email protected]/arith_decl.go:11:6: missing function body
../../../../pkg/mod/github.com/remyoudompheng/[email protected]/arith_decl.go:12:6: missing function body
../../../../pkg/mod/github.com/remyoudompheng/[email protected]/arith_decl.go:13:6: missing function body
../../../../pkg/mod/github.com/remyoudompheng/[email protected]/arith_decl.go:14:6: missing function body
../../../../pkg/mod/github.com/remyoudompheng/[email protected]/arith_decl.go:15:6: missing function body
../../../../pkg/mod/github.com/remyoudompheng/[email protected]/arith_decl.go:16:6: missing function body
../../../../pkg/mod/github.com/remyoudompheng/[email protected]/arith_decl.go:17:6: missing function body
../../../../pkg/mod/github.com/remyoudompheng/[email protected]/arith_decl.go:18:6: missing function body
../../../../pkg/mod/github.com/remyoudompheng/[email protected]/arith_decl.go:19:6: missing function body
../../../../pkg/mod/github.com/remyoudompheng/[email protected]/arith_decl.go:19:6: too many errors
?       github.com/oboukili/terraform-provider-argocd   [no test files]
FAIL    github.com/oboukili/terraform-provider-argocd/argocd [build failed]
FAIL
make: *** [testacc] Error 2
kind delete cluster --name argocd
Deleting cluster "argocd" ...

@jdmaguire jdmaguire changed the title Bump bigfft to support M1/arm64 Get tests working on M1/ARM 64 Dec 13, 2022
@oboukili oboukili merged commit 9d10bef into argoproj-labs:master Dec 13, 2022
@jdmaguire jdmaguire deleted the m1-test-support branch December 13, 2022 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants