Add script_artifact_passing example #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Elliot Gunton <[email protected]>
elliotgunton
added
semver:patch
flaviuvadan
reviewed
Apr 26, 2023
| whalesay(name="generate-artifact") | ||
| print_message( | ||
| name="consume-artifact", | ||
| arguments=[Artifact(name="message", from_="{{steps.generate-artifact.outputs.artifacts.hello-art}}")], |
There was a problem hiding this comment.
Is this PR a nice opportunity to implement get_artifact on step/task? 🤔 The same way there is a get_parameter
There was a problem hiding this comment.
Nvm, you created #595 exactly for that!
There was a problem hiding this comment.
I want to make a new PR where I'll do all the tasks in #595, and then the diff for the examples will show the changes from argo expressions to native hera 😄
flaviuvadan
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #591 with a script example to mirror
artifact_passing.pyupstream example.Will also be useful as an example of artifact passing noted in #595