Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update to go 1.17 and update deps #249

Merged
merged 2 commits into from
Jan 4, 2022
Merged

chore: Update to go 1.17 and update deps #249

merged 2 commits into from
Jan 4, 2022

Conversation

jkayani
Copy link
Member

@jkayani jkayani commented Dec 29, 2021

Description

Updates deps and updates to using go 1.17. Some special things to call out:

Checklist

Please make sure that your PR fulfills the following requirements:

  • Reviewed the guidelines for contributing to this repository
  • The commit message follows the Conventional Commits Guidelines.
  • Tests for the changes have been updated
  • Docs have been added / updated
  • Optional. My organization is added to USERS.md.

Type of Change

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

Other information

@jkayani jkayani self-assigned this Dec 29, 2021
sigs.k8s.io/yaml v1.3.0
)

require (
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the go 1.17 changes the format of this file to include 2 require() blocks, not sure what that's about yet

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the number of explicit requirements may be substantially larger in an expanded Go 1.17 go.mod file, the newly-added requirements on indirect dependencies in a go 1.17 module are maintained in a separate require block from the block containing direct dependencies.

https://go.dev/doc/go1.17#tools

@jkayani jkayani force-pushed the deps branch 4 times, most recently from 8c5c06e to 703d203 Compare December 30, 2021 17:04
@codecov-commenter
Copy link

codecov-commenter commented Dec 30, 2021

Codecov Report

Merging #249 (90d628f) into main (7db0f0c) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #249      +/-   ##
==========================================
- Coverage   75.33%   75.26%   -0.07%     
==========================================
  Files          19       19              
  Lines         750      748       -2     
==========================================
- Hits          565      563       -2     
  Misses        117      117              
  Partials       68       68              
Impacted Files Coverage Δ
pkg/backends/ibmsecretsmanager.go 75.00% <100.00%> (-0.52%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7db0f0c...90d628f. Read the comment docs.

@jkayani jkayani force-pushed the deps branch 2 times, most recently from ffb3e4c to 6bb45f8 Compare December 30, 2021 17:42
@jkayani jkayani marked this pull request as ready for review December 30, 2021 17:50
@jkayani jkayani requested a review from werne2j as a code owner December 30, 2021 17:50
@jkayani jkayani marked this pull request as draft December 30, 2021 17:50
@jkayani jkayani marked this pull request as ready for review December 30, 2021 17:50
@jkayani jkayani force-pushed the deps branch 2 times, most recently from da96077 to b040016 Compare January 4, 2022 15:05
Copy link
Member

@werne2j werne2j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@werne2j werne2j merged commit 87ae722 into main Jan 4, 2022
@werne2j werne2j deleted the deps branch January 4, 2022 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants