-
Notifications
You must be signed in to change notification settings - Fork 768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: create release 0.12.2 #1593
base: release-0.12
Are you sure you want to change the base?
chore: create release 0.12.2 #1593
Conversation
Signed-off-by: Ishita Sequeira <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we planning a new upstream operator release? If it is just for downstream release, I think we can ignore this PR for now. Your previous changes (#1591) should be sufficient for downstream.
We can make an exception this time i.e not release a z-stream upstream. I am working on a release automation so in future we should be able to do quick z-stream release of upstream operator.
@@ -1901,7 +1901,7 @@ spec: | |||
fieldPath: metadata.annotations['olm.targetNamespaces'] | |||
- name: ENABLE_CONVERSION_WEBHOOK | |||
value: "true" | |||
image: quay.io/argoprojlabs/argocd-operator:v0.12.0 | |||
image: quay.io/argoprojlabs/argocd-operator@sha256:f15781e2314d6baedcfc3bfa12181213d8d609803f73faecb2b8feddf3da4383 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like image is built for arm, should be amd64
$ docker inspect quay.io/argoprojlabs/argocd-operator@sha256:f15781e2314d6baedcfc3bfa12181213d8d609803f73faecb2b8feddf3da4383 |grep Arch
"Architecture": "arm64",
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we build multi-arch images ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I feel we should support other archs aswell. After release automation, that is on my todo. #264 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a make command to build a multi-arch image? I did not configure any arch-type while building the image. I think it took my default laptop arch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now, no. You need to modify image build commands and add --platform linux/amd64
flag.
diff --git a/Makefile b/Makefile
index 45c02a62..634356bb 100644
--- a/Makefile
+++ b/Makefile
@@ -110,7 +110,7 @@ run: manifests generate fmt vet ## Run a controller from your host.
REDIS_CONFIG_PATH="build/redis" go run -ldflags=$(LD_FLAGS) ./cmd/main.go
docker-build: test ## Build docker image with the manager.
- $(CONTAINER_RUNTIME) build --build-arg LD_FLAGS=$(LD_FLAGS) -t ${IMG} .
+ $(CONTAINER_RUNTIME) build --platform linux/amd64 --build-arg LD_FLAGS=$(LD_FLAGS) -t ${IMG} .
docker-push: ## Push docker image with the manager.
$(CONTAINER_RUNTIME) push ${IMG}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @svghadi !! Will build the image
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The image is updated on quay to be of type amd64
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the argocd-operator image either as multi-arch or amd64 supported. Other changes look good.
I think the fix that was merged should have a specific argocd-operator release as well for the feature to work if used only via argocd-operator. Although I am okay to skip publishing the image if needed. |
Signed-off-by: Siddhesh Ghadi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks
Signed-off-by: Ishita Sequeira <[email protected]>
5eb9c72
to
29b1823
Compare
What type of PR is this?
/kind chore
What does this PR do / why we need it:
create release 0.12.2