Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] split query param to ref|tag|sha #98

Merged
merged 2 commits into from
Jun 15, 2021

Conversation

noam-codefresh
Copy link
Collaborator

No description provided.

@noam-codefresh noam-codefresh self-assigned this Jun 15, 2021
@noam-codefresh noam-codefresh linked an issue Jun 15, 2021 that may be closed by this pull request
@roi-codefresh roi-codefresh changed the title split query param to ref|tag|sha [fix] split query param to ref|tag|sha Jun 15, 2021
pkg/application/application.go Show resolved Hide resolved
pkg/git/repository.go Outdated Show resolved Hide resolved
pkg/util/repospec.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 15, 2021

Codecov Report

Merging #98 (1e18ea4) into main (d436d76) will increase coverage by 2.26%.
The diff coverage is 87.06%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #98      +/-   ##
==========================================
+ Coverage   53.52%   55.78%   +2.26%     
==========================================
  Files          14       12       -2     
  Lines        2173     2067     -106     
==========================================
- Hits         1163     1153      -10     
+ Misses        933      836      -97     
- Partials       77       78       +1     
Impacted Files Coverage Δ
cmd/commands/repo.go 56.92% <50.00%> (-0.50%) ⬇️
pkg/git/repository.go 71.96% <86.79%> (+9.62%) ⬆️
cmd/commands/app.go 35.23% <100.00%> (-0.46%) ⬇️
pkg/application/application.go 58.62% <100.00%> (+0.13%) ⬆️
pkg/util/util.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d436d76...1e18ea4. Read the comment docs.

@noam-codefresh noam-codefresh merged commit b92a7ae into argoproj-labs:main Jun 15, 2021
@noam-codefresh noam-codefresh deleted the fix_clone_url_parse branch June 15, 2021 11:59
@roi-codefresh roi-codefresh linked an issue Jun 16, 2021 that may be closed by this pull request
noam-codefresh pushed a commit that referenced this pull request Jun 17, 2021
* revert #98 
* checkout after clone

Co-authored-by: roi.kramer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants