Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix github-enterprise client creation #353

Merged
merged 2 commits into from
Aug 2, 2022

Conversation

noam-codefresh
Copy link
Collaborator

No description provided.

@noam-codefresh noam-codefresh self-assigned this Jul 31, 2022
@@ -181,6 +181,7 @@ func RunAppCreate(ctx context.Context, opts *AppCreateOptions) error {
if opts.AppsCloneOpts.Auth.Password == "" {
opts.AppsCloneOpts.Auth.Username = opts.CloneOpts.Auth.Username
opts.AppsCloneOpts.Auth.Password = opts.CloneOpts.Auth.Password
opts.AppsCloneOpts.Provider = opts.CloneOpts.Provider
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have an issue that this one can close, can you link it?

@noam-codefresh noam-codefresh merged commit d7cfaa9 into argoproj-labs:main Aug 2, 2022
@noam-codefresh noam-codefresh deleted the fix-ghe branch August 2, 2022 09:52
kim-codefresh pushed a commit that referenced this pull request Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants