Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a fix to allow files with non __root roots to still unbundle correctly #66

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Entrox-Licher
Copy link
Contributor

This fix allows the program to properly unbundle all roots, not just __root (meaning it can safely load things made with both Atom and VS Code), but it will still bundle with the default of __root (once again ensuring it plays nice with both Atom and VS Code).

bundler/luabundler.go Outdated Show resolved Hide resolved
Copy link
Owner

@argonui argonui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm nervous about assuming about lengths of the strings. Can you add a few unit tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants