enable option to disable pin_memory in pytorch #239
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @zhenghh04 and @hariharan-devarajan,
This PR gives us option to disable pin memory in pytorch dataloader.
I encountered error while emulating stormer when we increase the prefetch factor since the memory is being reserved and cannot be released until the dataloader is finished.
Also, pin_memory is beneficial for GPU memory pinning which we do not use at all for DLIO [1, 2]
I set the default to True for backward compatibility, let me know if I should put
pin_memory=False
as default in the configuration.Reference:
[1] https://pytorch.org/tutorials/intermediate/pinmem_nonblock.html
[2] https://discuss.pytorch.org/t/when-to-set-pin-memory-to-true/19723/19