fix last step is not executed #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we have 730 steps, DLIO benchmark only executes until 729 The bug also persists when user specified `total_training_steps`
If `total_training_steps` is not specified, the default will be -1. Thus checking whether it is > 0 is needed
|
There is one bug. if |
hariharan-devarajan
requested changes
Oct 16, 2024
|
I think the last commit fixed the CI @hariharan-devarajan |
hariharan-devarajan
approved these changes
Oct 16, 2024
|
@zhenghh04 This is ready for merge as well. |
zhenghh04
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we have 730 steps, DLIO benchmark only executes until 729
The bug also persists when user specified
total_training_stepsFix: #235