Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to app run for Perlmutter #337

Merged
merged 4 commits into from
Apr 6, 2023
Merged

Updates to app run for Perlmutter #337

merged 4 commits into from
Apr 6, 2023

Conversation

cms21
Copy link
Contributor

@cms21 cms21 commented Apr 5, 2023

  • I added an option to pass options to the command line through launch_params
  • cpus-per-task is virtual cpus per task, i.e. threads on Perlmutter
  • mem=40G seemed oddly specific, unclear why this was introduced. This can now be passed through launch_params if needed.

@codecov-commenter
Copy link

codecov-commenter commented Apr 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03 ⚠️

Comparison is base (bfbf833) 61.22% compared to head (0e25cd4) 61.19%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #337      +/-   ##
==========================================
- Coverage   61.22%   61.19%   -0.03%     
==========================================
  Files         157      157              
  Lines        9537     9541       +4     
  Branches     1232     1233       +1     
==========================================
  Hits         5839     5839              
- Misses       3440     3444       +4     
  Partials      258      258              
Impacted Files Coverage Δ
balsam/platform/app_run/perlmutter.py 23.80% <0.00%> (-5.61%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cms21 cms21 merged commit 57a95f1 into main Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants