Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exception handling for 5xx server errors #334

Merged
merged 4 commits into from
Mar 31, 2023
Merged

exception handling for 5xx server errors #334

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7b95150
exception handling for 5xx server errors
Mar 28, 2023
115725d
updated exception to include more errors
Mar 30, 2023
07006fc
moved exception capturing down to a lower level for server communicat…
Mar 30, 2023
c00a72d
Merge branch 'main' into server-errors-fix
tomuram Mar 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion balsam/client/requests_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ def request(
except requests.Timeout as exc:
logger.warning(f"Attempt Retry of Timed-out request {http_method} {absolute_url}")
self.backoff(exc)
except requests.ConnectionError as exc:
except (requests.ConnectionError, requests.HTTPError) as exc:
logger.warning(f"Attempt retry ({self._attempt} of {self.retry_count}) of connection: {exc}")
self.backoff(exc)
else:
Expand Down