Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Perlmutter CPU as balsam site #332

Merged
merged 3 commits into from
Mar 28, 2023
Merged

Add Perlmutter CPU as balsam site #332

merged 3 commits into from
Mar 28, 2023

Conversation

tylern4
Copy link
Contributor

@tylern4 tylern4 commented Mar 27, 2023

I've been working with @cms21 on the DOE HPC Workflow training and wanted to add a Perlmutter CPU site for our users. This also makes some updates to the queue policies on Perlmutter from our docs. https://docs.nersc.gov/jobs/policy/#perlmutter-gpu

@cms21
Copy link
Contributor

cms21 commented Mar 27, 2023

We are going to go with this approach for now since it's implemented and working, but we may want to revisit it in the future. Another possible approach is to pass a parameter in the Batch Job instance that differentiates between gpu/cpu.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 83.33% and project coverage change: +0.01 🎉

Comparison is base (ba03a36) 61.29% compared to head (70e6a18) 61.30%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #332      +/-   ##
==========================================
+ Coverage   61.29%   61.30%   +0.01%     
==========================================
  Files         157      157              
  Lines        9537     9537              
  Branches     1232     1232              
==========================================
+ Hits         5846     5847       +1     
  Misses       3432     3432              
+ Partials      259      258       -1     
Impacted Files Coverage Δ
balsam/platform/compute_node/nersc_perlmutter.py 33.33% <66.66%> (ø)
balsam/platform/app_run/__init__.py 100.00% <100.00%> (ø)
balsam/platform/app_run/perlmutter.py 29.41% <100.00%> (ø)
balsam/platform/compute_node/__init__.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tomuram tomuram merged commit 23be44d into argonne-lcf:main Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants