Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staged pbs qstat #326

Merged
merged 8 commits into from
Mar 18, 2023
Merged

Staged pbs qstat #326

merged 8 commits into from
Mar 18, 2023

Conversation

cms21
Copy link
Contributor

@cms21 cms21 commented Mar 8, 2023

This changes the way pbs_sched gets info from the queue on the user's jobs. First qstat is executed and all the batch job ids for the user's jobs are fetched. Then qstat -f -F json is executed on just the jobs that belong to the user. It's unclear if this will fix #324 but it will decrease the amount of data in JSON format parsed by _parse_logs.

@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2023

Codecov Report

Patch coverage: 13.33% and project coverage change: +0.04 🎉

Comparison is base (37e3f62) 61.26% compared to head (c251141) 61.30%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #326      +/-   ##
==========================================
+ Coverage   61.26%   61.30%   +0.04%     
==========================================
  Files         157      157              
  Lines        9527     9537      +10     
  Branches     1230     1232       +2     
==========================================
+ Hits         5837     5847      +10     
  Misses       3432     3432              
  Partials      258      258              
Impacted Files Coverage Δ
balsam/platform/scheduler/pbs_sched.py 28.43% <13.33%> (-0.44%) ⬇️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tomuram tomuram merged commit ba03a36 into main Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

qstat results can't be parsed by JSON decoder
3 participants