Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add record timestamps to export #5754

Conversation

jfcalvo
Copy link
Member

@jfcalvo jfcalvo commented Dec 13, 2024

Description

Only adding record's inserted_at and updated_at to the list of record attributes used with HubDatasetExport.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested

  • Changing the test suite for HubDatasetExporter.

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • I confirm My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

…ttributes used to export datasets to the hub
@jfcalvo jfcalvo requested a review from frascuchon December 13, 2024 09:14
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.10%. Comparing base (0924864) to head (edbb88d).
Report is 1 commits behind head on feat/export-dataset-to-hub-feature-branch.

Additional details and impacted files
@@                              Coverage Diff                              @@
##           feat/export-dataset-to-hub-feature-branch    #5754      +/-   ##
=============================================================================
- Coverage                                      92.12%   92.10%   -0.02%     
=============================================================================
  Files                                            161      161              
  Lines                                           6894     6894              
=============================================================================
- Hits                                            6351     6350       -1     
- Misses                                           543      544       +1     
Flag Coverage Δ
argilla-server 92.10% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jfcalvo jfcalvo merged commit 072070a into feat/export-dataset-to-hub-feature-branch Dec 13, 2024
6 checks passed
@jfcalvo jfcalvo deleted the feat/add-record-timestamps-to-export branch December 13, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants