Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] [TESTS] Remove custom isoformat parsing and let pydantic do the work #5752

Merged
merged 2 commits into from
Dec 12, 2024
Merged

[BUGFIX] [TESTS] Remove custom isoformat parsing and let pydantic do the work #5752

merged 2 commits into from
Dec 12, 2024

Conversation

frascuchon
Copy link
Member

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • I confirm My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@frascuchon frascuchon requested a review from jfcalvo December 12, 2024 09:54
@frascuchon frascuchon force-pushed the bugfixes/remove-custom-isoformat-parsing branch from 301e87f to f66c1f6 Compare December 12, 2024 10:02
@frascuchon frascuchon merged commit a74d3eb into develop Dec 12, 2024
7 checks passed
@frascuchon frascuchon deleted the bugfixes/remove-custom-isoformat-parsing branch December 12, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfcalvo jfcalvo jfcalvo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frascuchon @jfcalvo