Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] argilla: allow change default distribution values #5719

Conversation

frascuchon
Copy link
Member

@frascuchon frascuchon commented Nov 27, 2024

Description

When creating a rg.Settings instance with default distribution, updates on the min_submitted attribute do not take effect.

settings = rg.Settings(fields=...)

settings.distribution.min_submitted= 3 # this not takes effect

Maybe related to #5718

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • I confirm My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@frascuchon frascuchon changed the title [BUGFIXES] argilla: allow change default distribution values [BUGFIX] argilla: allow change default distribution values Nov 27, 2024
@davidberenstein1957
Copy link
Member

@frascuchon not related to #5718 because that was an update through the UI that did not seem to take place.

@frascuchon frascuchon merged commit 8342ca7 into releases/2.5.0 Nov 28, 2024
7 checks passed
@frascuchon frascuchon deleted the bugfixes/argilla/allow-change-default-distribution-values branch November 28, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants