Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Resolve failing tests after pydantic V2 merge #5700

Merged

Conversation

frascuchon
Copy link
Member

Description

This PR resolves failing tests after pydantic V2 upgrade:

  • Changes the expected error details
  • Catch TypeError exception inside validator to resolve as a 422 status response

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • I confirm My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@frascuchon frascuchon requested a review from jfcalvo November 20, 2024 15:23
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.79%. Comparing base (f346a84) to head (f7846ae).
Report is 32 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5700      +/-   ##
===========================================
+ Coverage    91.08%   91.79%   +0.70%     
===========================================
  Files          150      161      +11     
  Lines         6250     6738     +488     
===========================================
+ Hits          5693     6185     +492     
+ Misses         557      553       -4     
Flag Coverage Δ
argilla-server 91.79% <100.00%> (+0.70%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@frascuchon frascuchon merged commit 1c8f528 into develop Nov 20, 2024
6 checks passed
@frascuchon frascuchon deleted the bugfix/resolve-tests-errors-after-pydantic-upgrade branch November 20, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants