Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add support to update record fields #5685

Merged
merged 18 commits into from
Dec 11, 2024

Conversation

frascuchon
Copy link
Member

@frascuchon frascuchon commented Nov 12, 2024

Description

This PR adds backend support to update record fields.

Type of change

  • Improvement (change adding some improvement to an existing functionality)

How Has This Been Tested

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • I confirm My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.25%. Comparing base (0cbbdeb) to head (8210888).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5685      +/-   ##
===========================================
+ Coverage    91.98%   92.25%   +0.26%     
===========================================
  Files          161      161              
  Lines         6778     6676     -102     
===========================================
- Hits          6235     6159      -76     
+ Misses         543      517      -26     
Flag Coverage Δ
argilla-server 92.25% <100.00%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frascuchon frascuchon requested a review from jfcalvo November 12, 2024 12:04
@frascuchon frascuchon marked this pull request as ready for review November 12, 2024 12:04
@frascuchon frascuchon added this to the v2.5.0 milestone Nov 14, 2024
@jfcalvo jfcalvo modified the milestones: v2.5.0, v2.6.0 Nov 20, 2024
@frascuchon frascuchon merged commit 0487936 into develop Dec 11, 2024
1 check was pending
@frascuchon frascuchon deleted the feat/add-support-to-update-record-fields branch December 11, 2024 13:45
@davidberenstein1957
Copy link
Member

@nataliaElv @frascuchon do you remember if there was a dedicated issues for this? I feel there should be but I could not find and I wanted to ping users there to mention we added this support.

@davidberenstein1957
Copy link
Member

I believe @cceyda once requested this too :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants