Dataset Creation UI fixes & Improvements #5670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
leiyre
commented
Nov 5, 2024
•
leiyre
commented
- Rating values validate min / max
- Question name format and renaming
- Minor style adjustments
- Show required / not required in the form preview
- Redirect from /new/repoId to /repoId
- Redirect to error page when repoId is invalid
|
The URL of the deployed environment for this PR is https://argilla-quickstart-pr-5670-ki24f765kq-no.a.run.app |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5670 +/- ##
===========================================
+ Coverage 91.08% 91.21% +0.12%
===========================================
Files 150 150
Lines 6250 6250
===========================================
+ Hits 5693 5701 +8
+ Misses 557 549 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
frascuchon
reviewed
Nov 6, 2024
argilla-frontend/v1/infrastructure/repositories/HubRepository.ts
Outdated
Show resolved
Hide resolved
# Description <!-- Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change. --> Closes #5633 **Type of change** <!-- Please delete options that are not relevant. Remember to title the PR according to the type of change --> - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) **How Has This Been Tested** <!-- Please add some reference about how your feature has been tested. --> **Checklist** <!-- Please go over the list and make sure you've taken everything into account --> - I added relevant documentation - I followed the style guidelines of this project - I did a self-review of my code - I made corresponding changes to the documentation - I confirm My changes generate no new warnings - I have added tests that prove my fix is effective or that my feature works - I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/) --------- Co-authored-by: José Francisco Calvo <[email protected]> Co-authored-by: José Francisco Calvo <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
frascuchon
reviewed
Nov 6, 2024
...lla-frontend/components/features/dataset-creation/configuration/DatasetConfigurationForm.vue
Outdated
Show resolved
Hide resolved
….com/argilla-io/argilla into fix/dataset-creation-ui-improvements
frascuchon
reviewed
Nov 8, 2024
| @@ -144,7 +145,7 @@ export default { | |||
| return Math.max( | |||
| ...this.dataset.selectedSubset.questions.map((question) => { | |||
| const numberInName = question.name.split("_").pop(); | |||
| return parseInt(numberInName); | |||
| return parseInt(numberInName) || 0; | |||
There was a problem hiding this comment.
How can a mapped column named "column_10" influence this?
There was a problem hiding this comment.
In that case the next created question name will be "questionType_11"
frascuchon
approved these changes
Nov 8, 2024
frascuchon
changed the title
frascuchon
added a commit
that referenced
this pull request
Nov 8, 2024
- [x] Rating values validate min / max - [x] Question name format and renaming - [x] Minor style adjustments - [x] Show required / not required in the form preview - [x] Redirect from /new/repoId to /repoId - [x] Redirect to error page when repoId is invalid --------- Co-authored-by: Francisco Aranda <[email protected]> Co-authored-by: Paco Aranda <[email protected]> Co-authored-by: José Francisco Calvo <[email protected]> Co-authored-by: José Francisco Calvo <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.