fix: improve logic for detecting ChatFields #5667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The URL of the deployed environment for this PR is https://argilla-quickstart-pr-5667-ki24f765kq-no.a.run.app |
frascuchon
reviewed
Nov 5, 2024
Comment on lines
+48
to
+49
| role, | ||
| content, |
There was a problem hiding this comment.
We're losing info by keeping only the first entry of value on this line (which is a dictionary of feature). This can introduce errors later. (Not for handling on this PR) cc @damianpumar
frascuchon
reviewed
Nov 5, 2024
Comment on lines
+10
to
+11
| role?: string; | ||
| content?: string; |
There was a problem hiding this comment.
I don't fully understand this data structure but I think role and content are quite specific to be part of a general structure. Anyway, this is something to review with @damianpumar.
We can go on with this solution if everything is working well.
frascuchon
approved these changes
Nov 5, 2024
frascuchon
added a commit
that referenced
this pull request
Nov 8, 2024
Check the role and content properties to validate the chat field --------- Co-authored-by: Francisco Aranda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check the role and content properties to validate the chat field