[BUGFIX] argilla frontend: redirect after login

.github/workflows/argilla.yml

@@ -24,7 +24,7 @@ jobs:
   build:
     services:
       argilla-server:
-        image: argilladev/argilla-hf-spaces:develop
+        image: argilladev/argilla-hf-spaces:pr-5572
         ports:
           - 6900:6900
         env:

argilla-frontend/middleware/route-guard.ts

@@ -28,12 +28,9 @@ export default ({ $auth, route, redirect }: Context) => {
       if (route.params.omitCTA) return;
 
       if (isRunningOnHuggingFace()) {
-        // eslint-disable-next-line @typescript-eslint/no-unused-vars
-        const { redirect: _, ...query } = route.query;
-
         return redirect({
           name: "welcome-hf-sign-in",
-          query,
+          query: route.query,
         });
       }
       break;

argilla-frontend/pages/oauth/_provider/useOAuthViewModel.ts

@@ -16,19 +16,28 @@ export const useOAuthViewModel = () => {
     await tryLogin();
   });
 
+  const redirect = () => {
+    let { redirect } = router.getQuery();
+    if (Array.isArray(redirect)) {
+      redirect = redirect[0];
+    }
+
+    router.go(redirect || "/");
+  };
+
   const tryLogin = async () => {
     const { params, query } = routes.value;
 
     const provider = params.provider as ProviderType;
 
     try {
       await oauthLoginUseCase.login(provider, query);
+      redirect();
     } catch {
       notification.notify({
         message: t("argilla.api.errors::UnauthorizedError"),
         type: "danger",
       });
-    } finally {
       router.go("/");
     }
   };

argilla-server/tests/unit/api/handlers/v1/test_oauth2.py

@@ -89,14 +89,15 @@ async def test_provider_huggingface_authentication(
     ):
         with mock.patch("argilla_server.security.settings.Settings.oauth", new_callable=lambda: default_oauth_settings):
             response = await async_client.get(
-                "/api/v1/oauth2/providers/huggingface/authentication", headers=owner_auth_header
+                "/api/v1/oauth2/providers/huggingface/authentication?extra=params", headers=owner_auth_header
             )
             assert response.status_code == 303
 
             redirect_url = URL(response.headers.get("location"))
             assert redirect_url.scheme == b"https"
             assert redirect_url.host == b"huggingface.co"
             assert b"/oauth/authorize?response_type=code&client_id=client_id" in redirect_url.target
+            assert b"&extra=params" in redirect_url.target
 
     async def test_provider_authentication_with_oauth_disabled(
         self,

argilla/CHANGELOG.md

@@ -32,6 +32,10 @@ These are the section headers that we use:
 
 - Removed name sanitizing for dataset settings names. This may cause issues with old server versions. Especially when working with `from_hub`. ([#5574](https://github.com/argilla-io/argilla/pull/5574))
 
+### Removed
+
+- Removed name sanitizing for dataset settings names. This may cause issues with old server versions. Especially when working with `from_hub`. ([#5574](https://github.com/argilla-io/argilla/pull/5574))
+
 ## [2.3.0](https://github.com/argilla-io/argilla/compare/v2.2.2...v2.3.0)
 
 ### Added