[BUGFIX] argilla: support multi label values #5625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frascuchon
changed the base branch from
develop
to
feat/argilla-direct-feature-branch
frascuchon
commented
Oct 24, 2024
Comment on lines
+275
to
+294
| image_columns = [] | ||
| class_label_columns = [] | ||
| class_label_sequence_columns = [] | ||
|
|
||
| for name, feature in hf_dataset.features.items(): | ||
| if isinstance(feature, Image): | ||
| casted_features[Image].append(name) | ||
| if isinstance(feature, ClassLabel): | ||
| casted_features[ClassLabel].append(name) | ||
| image_columns.append(name) | ||
| elif isinstance(feature, ClassLabel): | ||
| class_label_columns.append(name) | ||
| elif isinstance(feature, Sequence) and isinstance(feature.feature, ClassLabel): | ||
| class_label_sequence_columns.append(name) | ||
|
|
||
| if image_columns: | ||
| hf_dataset = _cast_images_as_urls(hf_dataset, image_columns) | ||
|
|
||
| if class_label_columns: | ||
| hf_dataset = _cast_classlabels_as_strings(hf_dataset, class_label_columns) | ||
|
|
||
| for feature_type, columns in casted_features.items(): | ||
| hf_dataset = FEATURE_CASTERS[feature_type](hf_dataset, columns) | ||
| if class_label_sequence_columns: | ||
| hf_dataset = _cast_class_label_sequence_as_string_list(hf_dataset, class_label_sequence_columns) |
There was a problem hiding this comment.
All this logic could be improved by using a general map with batches and convert the values on each map.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/argilla-direct-feature-branch #5625 +/- ##
======================================================================
+ Coverage 91.20% 91.24% +0.03%
======================================================================
Files 150 150
Lines 6242 6246 +4
======================================================================
+ Hits 5693 5699 +6
+ Misses 549 547 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
burtenshaw
approved these changes
Oct 24, 2024
frascuchon
merged commit 3fbbc6e
into
feat/argilla-direct-feature-branch
6 of 7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes problems when a class label sequence is mapped as suggestions.
NOTE: This PR does not infer a sequence of class labels as multi-label questions. Only prevent errors when a sequence of class labels column is used as a suggestion (or other kinds of properties in argilla)
Type of change
How Has This Been Tested
Checklist