Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve HubDataset image processing support #5606

Merged

Conversation

jfcalvo
Copy link
Member

@jfcalvo jfcalvo commented Oct 17, 2024

Description

This PR adds the following changes related to how HubDataset import functionality process rows with images:

  • If the image has not format we transform the image to png.
  • We convert images to RGB color space to avoid problems with other unsupported color spaces.

Refs argilla-io/roadmap#21

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested

  • Manually testing microsoft/cats_vs_dogs dataset.

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • I confirm My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@jfcalvo jfcalvo requested a review from frascuchon October 17, 2024 09:07
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (feat/add-hub-dataset-import@08ebe28). Learn more about missing BASE report.

Additional details and impacted files
@@                      Coverage Diff                       @@
##             feat/add-hub-dataset-import    #5606   +/-   ##
==============================================================
  Coverage                               ?   91.15%           
==============================================================
  Files                                  ?      150           
  Lines                                  ?     6250           
  Branches                               ?        0           
==============================================================
  Hits                                   ?     5697           
  Misses                                 ?      553           
  Partials                               ?        0           
Flag Coverage Δ
argilla-server 91.15% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from feat/add-support-for-class-labels-and-casting-rows to feat/add-hub-dataset-import October 18, 2024 10:55
@jfcalvo jfcalvo merged commit 312551a into feat/add-hub-dataset-import Oct 18, 2024
1 of 2 checks passed
@jfcalvo jfcalvo deleted the feat/improve-hub-dataset-image-support branch October 18, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants