Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a fixed number of rows to take importing dataset from Hub #5597

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

jfcalvo
Copy link
Member

@jfcalvo jfcalvo commented Oct 15, 2024

Description

I have added a number of row to take importing a dataset from the hub. Specifically 500K rows. This can help us to avoid importing really big datasets with millions of rows into Argilla.

Refs argilla-io/roadmap#21

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested

  • Manually tested importing a dataset with a big number of records (> 500K)

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • I confirm My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.08%. Comparing base (f3e33bd) to head (15301f0).
Report is 4 commits behind head on feat/add-hub-dataset-import.

Files with missing lines Patch % Lines
argilla-server/src/argilla_server/jobs/hub_jobs.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@                       Coverage Diff                       @@
##           feat/add-hub-dataset-import    #5597      +/-   ##
===============================================================
+ Coverage                        91.05%   91.08%   +0.02%     
===============================================================
  Files                              150      150              
  Lines                             6204     6211       +7     
===============================================================
+ Hits                              5649     5657       +8     
+ Misses                             555      554       -1     
Flag Coverage Δ
argilla-server 91.08% <50.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@burtenshaw
Copy link
Contributor

@jfcalvo This should be changed to 10_000 for the first iteration.

cc @frascuchon

@jfcalvo jfcalvo merged commit 3d1f04f into feat/add-hub-dataset-import Oct 17, 2024
4 of 6 checks passed
@jfcalvo jfcalvo deleted the feat/hub-dataset-import-max-take branch October 17, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants