-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add metadata
support for datasets
#5586
Merged
jfcalvo
merged 7 commits into
feat/argilla-direct-feature-branch
from
feat/add-dataset-metadata
Oct 15, 2024
Merged
feat: Add metadata
support for datasets
#5586
jfcalvo
merged 7 commits into
feat/argilla-direct-feature-branch
from
feat/add-dataset-metadata
Oct 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/argilla-direct-feature-branch #5586 +/- ##
======================================================================
+ Coverage 91.20% 91.22% +0.01%
======================================================================
Files 145 145
Lines 6026 6037 +11
======================================================================
+ Hits 5496 5507 +11
Misses 530 530
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jfcalvo
commented
Oct 8, 2024
argilla-server/tests/unit/api/handlers/v1/datasets/test_update_dataset.py
Show resolved
Hide resolved
frascuchon
reviewed
Oct 14, 2024
...er/src/argilla_server/alembic/versions/660d6c6b3360_add_metadata_column_to_datasets_table.py
Show resolved
Hide resolved
frascuchon
approved these changes
Oct 14, 2024
jfcalvo
merged commit Oct 15, 2024
2ecca9d
into
feat/argilla-direct-feature-branch
5 of 6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR add a new
metadata
column todatasets
table and the following changes:metadata
values.metadata
values.metadata
attribute is included onDataset
schema so themetadata
of a dataset is exposed in our API.Refs argilla-io/roadmap#21
Type of change
How Has This Been Tested
Checklist