Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change dataset publish validation from at least one required field to at least one field (required or not) #5569

Conversation

jfcalvo
Copy link
Member

@jfcalvo jfcalvo commented Oct 4, 2024

Description

In this PR we are changing how dataset publish validation works moving from:

  • At least one required field to be a valid publishable dataset.

To:

  • At least one field (required or not) to be a valid publishable dataset.

Refs argilla-io/roadmap#21

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested

  • Modifying test suite.

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • I confirm My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@jfcalvo jfcalvo requested a review from frascuchon October 4, 2024 14:07
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.30%. Comparing base (6c5d5e9) to head (3b49f6d).
Report is 1 commits behind head on feat/argilla-direct-feature-branch.

Additional details and impacted files
@@                         Coverage Diff                         @@
##           feat/argilla-direct-feature-branch    #5569   +/-   ##
===================================================================
  Coverage                               91.30%   91.30%           
===================================================================
  Files                                     145      145           
  Lines                                    6037     6037           
===================================================================
  Hits                                     5512     5512           
  Misses                                    525      525           
Flag Coverage Δ
argilla-server 91.30% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jfcalvo jfcalvo merged commit 2a98e73 into feat/argilla-direct-feature-branch Oct 7, 2024
5 of 6 checks passed
@jfcalvo jfcalvo deleted the feat/dataset-publish-at-least-one-field branch October 7, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants