Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove response.upserted webhook event #5494

Conversation

jfcalvo
Copy link
Member

@jfcalvo jfcalvo commented Sep 16, 2024

Description

As discussed we want to stop using response.upserted webhook event and instead use response.created or response.updated when a response is upserted.

Refs #1836

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested

  • Running test suite.

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • I confirm My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@jfcalvo jfcalvo requested a review from frascuchon September 16, 2024 12:46
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (feat/add-webhooks-feature-branch@3fb3d66). Learn more about missing BASE report.

Additional details and impacted files
@@                         Coverage Diff                         @@
##             feat/add-webhooks-feature-branch    #5494   +/-   ##
===================================================================
  Coverage                                    ?   91.40%           
===================================================================
  Files                                       ?      157           
  Lines                                       ?     6321           
  Branches                                    ?        0           
===================================================================
  Hits                                        ?     5778           
  Misses                                      ?      543           
  Partials                                    ?        0           
Flag Coverage Δ
argilla-server 91.40% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from chore/move-webhooks-outside-api-folder to feat/add-webhooks-feature-branch September 16, 2024 14:14
@jfcalvo jfcalvo merged commit cbf28c7 into feat/add-webhooks-feature-branch Sep 16, 2024
1 of 2 checks passed
@jfcalvo jfcalvo deleted the feat/remove-response-upserted-webhook-event branch September 16, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants