Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVEMENT] Update pip when building docker image #4907

Merged

Conversation

frascuchon
Copy link
Member

The latests CI builds are taking longer than expected (around 8 minutes) - here an example - because pip needs to download multiple package version to match the proper dependency.

This should be fixed by upgrading pip. This PR includes a pip upgrade when building the docker image.

@frascuchon frascuchon changed the title chore: Update pip when building docker image [WIP] Update pip when building docker image May 29, 2024
@frascuchon frascuchon requested a review from jfcalvo May 29, 2024 15:38
Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.95%. Comparing base (39b169c) to head (b507190).

Additional details and impacted files
@@                 Coverage Diff                  @@
##           releases/1.29.0    #4907       +/-   ##
====================================================
+ Coverage            66.65%   90.95%   +24.29%     
====================================================
  Files                  399      206      -193     
  Lines                21935    10094    -11841     
====================================================
- Hits                 14621     9181     -5440     
+ Misses                7314      913     -6401     
Flag Coverage Δ
argilla ?
argilla-server 90.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frascuchon frascuchon changed the title [WIP] Update pip when building docker image [IMPROVEMENT] Update pip when building docker image May 29, 2024
@frascuchon frascuchon merged commit 23c3d54 into releases/1.29.0 May 29, 2024
10 of 16 checks passed
@frascuchon frascuchon deleted the chore/update-pip-for-server-docker-image branch May 29, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants